Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EmptyState - make titleText optional #10971

Closed
kmcfaul opened this issue Sep 11, 2024 · 0 comments · Fixed by #10987
Closed

EmptyState - make titleText optional #10971

kmcfaul opened this issue Sep 11, 2024 · 0 comments · Fixed by #10987
Assignees
@tlabaj
Labels
P1 ⭐ top priority issues
Milestone
Penta final release

Comments

@kmcfaul
Copy link
Contributor

kmcfaul commented Sep 11, 2024

Also remove the wrapping div if titletext and children are not present (like the previous implementation).
@kmcfaul kmcfaul added the Feature end user feature that requires design to define this, i.e. changes or augments the user experience. label Sep 11, 2024
@kmcfaul kmcfaul added P1 ⭐ top priority issues and removed Feature end user feature that requires design to define this, i.e. changes or augments the user experience. v6 alpha bug labels Sep 11, 2024
@kmcfaul kmcfaul added this to the Penta final release milestone Sep 11, 2024
@tlabaj tlabaj mentioned this issue Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tlabaj tlabaj

Labels
P1 ⭐ top priority issues
Projects
PatternFly Issues
Archived in project
Milestone
Penta final release
Development

Successfully merging a pull request may close this issue.

fix(empty state): Do not require titleText prop) tlabaj/patternfly-react
2 participants
@tlabaj @kmcfaul