Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Table - columns that are not sortable should not have aria-sort #11023

Open
rhamilto opened this issue Sep 18, 2024 · 0 comments
Open

Bug - Table - columns that are not sortable should not have aria-sort #11023

rhamilto opened this issue Sep 18, 2024 · 0 comments

Comments

@rhamilto
Copy link
Member

rhamilto commented Sep 18, 2024

Describe the problem
Per the latest W3C specifications and accessibility guidelines, the aria-sort attribute should only have values of “ascending”, “descending”, or “other” to indicate the sort order. If sorting does not exist for the column, no aria-sort attribute should be added.

'aria-sort': isSortedBy ? `${sortBy.direction}ending` : 'none',
currently outputs a value of "none" for columns that are not sortable but should not.

How do you reproduce the problem?
In OpenShift Management Console, upgrade axe-core and cypress-axe to the latest versions, run other-routes.cy.ts, and note the aria-sort="none" accessibility failures.

Expected behavior
No aria-sort="none" accessibility issues should be present after upgrading axe-core and cypress-axe to the latest versions in OpenShift Management Console.

Is this issue blocking you?
Yes. We cannot upgrade axe-core and cypress-axe in OpenShift Management Console as a result of this bug, which in turn is blocking the ability to upgrade monaco-editor.

Screenshots
Screenshot 2024-09-18 at 5 07 11 PM

cc: @logonoff

@rhamilto rhamilto added the bug label Sep 18, 2024
@rhamilto rhamilto changed the title Bug - Table - columns that are not sortable should not have aria-label Bug - Table - columns that are not sortable should not have aria-sort Sep 18, 2024
@tlabaj tlabaj added this to the Prioritized Backlog milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

3 participants