Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a loader prop for the Select components in v5.4.0 #11024

Open
aakankshabhende opened this issue Sep 19, 2024 · 4 comments
Open

Add a loader prop for the Select components in v5.4.0 #11024

aakankshabhende opened this issue Sep 19, 2024 · 4 comments
Labels
DevX enhances the consumer developer experience but does not change the experience for the end-user

Comments

@aakankshabhende
Copy link

Describe the enhancement or change
Currently, we don't have a loader prop for Select components in v5.4.0 due to which we have to manually add a spinner in the component while the data is getting fetched.

@aakankshabhende aakankshabhende added the DevX enhances the consumer developer experience but does not change the experience for the end-user label Sep 19, 2024
@tlabaj
Copy link
Contributor

tlabaj commented Sep 19, 2024

@aakankshabhende here is the example of how to implement the view more functionality with our select component. https://www.patternfly.org/components/menus/select#with-view-more.

Does this solve yu\our use case?

@aakankshabhende
Copy link
Author

Actually, I wanted something similar to the LoadingVariant in PF4 where the loader was besides the placeholder.

@tlabaj
Copy link
Contributor

tlabaj commented Sep 20, 2024

@aakankshabhende can you please link the specific example. I can't seem to find it.

@aakankshabhende
Copy link
Author

Sorry for the late response. We get the loader when the value is selected and getting updated. Please check the attached video

Screen.Recording.2024-09-25.at.3.41.08.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevX enhances the consumer developer experience but does not change the experience for the end-user
Projects
Status: Needs info
Development

No branches or pull requests

2 participants