You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is this a new component or an extension of an existing one?
What is the existing component, if any?
Existing, MenuToggle, ToolbarFilter
When using PF tokens to create a custom theme, MenuToggle and ToolbarFilter use default icons in PF that currently cannot be changed via a prop since the prop does not exist, while components like Label, Alert, and Button, offer this functionality.
An alternative option was discussed at today's working session (cc @mcoker), which would include adding support for custom icons directly to react-icons and then importing any custom overrides.
Describe the feature
A clear and concise description of the new feature. What is the expected behavior?
Are there visuals for this feature? If applicable, please include examples for each state and for varying widths
See below. MUI uses a different toggle icon for their menu toggle.
Include screenshots or links to Marvel or other mockups.
MUI:
PF:
Any other information?
Would it be possible to prioritize this work for an upcoming sprint to align with RHOAI priorities for the MUI theming effort @nicolethoen ?
The text was updated successfully, but these errors were encountered:
jenny-s51
added
the
Feature
end user feature that requires design to define this, i.e. changes or augments the user experience.
label
Sep 24, 2024
Thank you, @tlabaj . Here’s an update from our sync this morning:
It was clarified by PF that customization support is currently focused on composable components, such as buttons and alerts, to ensure effective usage and mitigate any potential issues with extensive customization. cc @andrew-ronaldson .
Due to current priorities and resource constraints, exploring the extensive scope of this customization effort is not on the roadmap at this time. However, the team is focused on developing a more cohesive icon set for PF components which will drive consistency among PF components which apply these icons.
Is this a new component or an extension of an existing one?
What is the existing component, if any?
Existing, MenuToggle, ToolbarFilter
When using PF tokens to create a custom theme, MenuToggle and ToolbarFilter use default icons in PF that currently cannot be changed via a prop since the prop does not exist, while components like Label, Alert, and Button, offer this functionality.
An alternative option was discussed at today's working session (cc @mcoker), which would include adding support for custom icons directly to react-icons and then importing any custom overrides.
Related: #10634
Describe the feature
A clear and concise description of the new feature. What is the expected behavior?
Are there visuals for this feature? If applicable, please include examples for each state and for varying widths
See below. MUI uses a different toggle icon for their menu toggle.
Include screenshots or links to Marvel or other mockups.
MUI:
PF:
Any other information?
Would it be possible to prioritize this work for an upcoming sprint to align with RHOAI priorities for the MUI theming effort @nicolethoen ?
The text was updated successfully, but these errors were encountered: