Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons - add support for custom icons #11055

Open
jenny-s51 opened this issue Sep 24, 2024 · 2 comments
Open

Icons - add support for custom icons #11055

jenny-s51 opened this issue Sep 24, 2024 · 2 comments
Labels
Feature end user feature that requires design to define this, i.e. changes or augments the user experience.

Comments

@jenny-s51
Copy link
Contributor

jenny-s51 commented Sep 24, 2024

Is this a new component or an extension of an existing one?
What is the existing component, if any?

Existing, MenuToggle, ToolbarFilter

When using PF tokens to create a custom theme, MenuToggle and ToolbarFilter use default icons in PF that currently cannot be changed via a prop since the prop does not exist, while components like Label, Alert, and Button, offer this functionality.

An alternative option was discussed at today's working session (cc @mcoker), which would include adding support for custom icons directly to react-icons and then importing any custom overrides.

Related: #10634

Describe the feature
A clear and concise description of the new feature. What is the expected behavior?

Are there visuals for this feature? If applicable, please include examples for each state and for varying widths

See below. MUI uses a different toggle icon for their menu toggle.

Include screenshots or links to Marvel or other mockups.
MUI:
Screenshot 2024-09-24 at 4 27 39 PM
Screenshot 2024-09-25 at 3 21 01 PM

PF:
Screenshot 2024-09-24 at 4 28 05 PM
Screenshot 2024-09-25 at 3 26 46 PM

Any other information?
Would it be possible to prioritize this work for an upcoming sprint to align with RHOAI priorities for the MUI theming effort @nicolethoen ?

@jenny-s51 jenny-s51 added the Feature end user feature that requires design to define this, i.e. changes or augments the user experience. label Sep 24, 2024
@tlabaj
Copy link
Contributor

tlabaj commented Oct 3, 2024

Let's set up a meeting to talk about this.

@jenny-s51
Copy link
Contributor Author

Thank you, @tlabaj . Here’s an update from our sync this morning:

It was clarified by PF that customization support is currently focused on composable components, such as buttons and alerts, to ensure effective usage and mitigate any potential issues with extensive customization. cc @andrew-ronaldson .

Due to current priorities and resource constraints, exploring the extensive scope of this customization effort is not on the roadmap at this time. However, the team is focused on developing a more cohesive icon set for PF components which will drive consistency among PF components which apply these icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature end user feature that requires design to define this, i.e. changes or augments the user experience.
Projects
Status: Needs info
Development

No branches or pull requests

2 participants