Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor chart imports #11090

Closed
dlabrecq opened this issue Sep 27, 2024 · 0 comments · Fixed by #11091
Closed

Refactor chart imports #11090

dlabrecq opened this issue Sep 27, 2024 · 0 comments · Fixed by #11091
Labels
P1 ⭐ top priority issues v6 alpha bug

Comments

@dlabrecq
Copy link
Member

dlabrecq commented Sep 27, 2024

In order to support Victory and Apache ECharts, I'd like make Victory a peer dependency.
That way, users can choose which library they want to use.

If devs don't want Sankey, they can omit the package from the install or vice versa.
ConsoleDot has already done this with their @redhat-cloud-services packages.
For example, react-core, react-icons, and react-table are peer dependencies for frontend-components.

I would also like our imports to be:
import { Chart } from '@patternfly/react-charts/victory';
import { Sankey } from '@patternfly/react-charts/echarts';

We could introduce this change separately, but thinking v6 would be a better time to make this type of change.
Peer dependencies would make it a lot easier to introduce new features, regardless of the library we choose.
And probably less disruptive if we do it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 ⭐ top priority issues v6 alpha bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants