Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config from pyproject.toml or .git-changelogrc #54

Closed
oesteban opened this issue Aug 18, 2023 · 2 comments · Fixed by #55
Closed

Config from pyproject.toml or .git-changelogrc #54

oesteban opened this issue Aug 18, 2023 · 2 comments · Fixed by #55

Comments

@oesteban
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Allow permanent configuration through either of those files.

Describe the solution you'd like

Permit customizing execution by writing permanent configs on some project's file.

Describe alternatives you've considered

Makefile, storing the command line on a text file?

Additional context

In attempting an implementation for #48, it seemed easier to write the modifications to the code convention as a toml / yaml dictionary. Once that way of writing the modifications is implemented, we could move on to creating a language for the CLI.

@pawamoy
Copy link
Owner

pawamoy commented Aug 18, 2023

Could you elaborate a bit? Do you want to allow declaring a custom convention in YAML/TOML? I'd advise against that. I actually tried to implement such a thing in the past, and unfortunately declarative languages will never be enough. You'll hit incompatibilities in how (multi)line strings are handled between Python and TOML, especially for regular expressions. Well, that's only my experience, so of course if you manage to code something elegant and powerful, I'll review it. But I would very much not like to maintain a super complex configuration trying to code complex logic in TOML. I'd prefer some hook system to easily create a custom convention in Python directly.

If I misunderstood your intentions, let me know! And if you just meant (for now) to have a config file for the current options, I'm OK with that! Lets go with TOML, reading from pyproject.toml, .git-changelog.toml, config/git-changelog.toml, or .config/git-changelog.toml :)

Thanks for your contributions! 🚀

@oesteban
Copy link
Contributor Author

Yes, it would be a two-step process. First, just cover the current CLI options and after that, on a separate effort, deal with the complex configurations.

Thanks for the list of files 👍 I'm currently finishing up a PR :)

oesteban added a commit to oesteban/git-changelog that referenced this issue Aug 18, 2023
Permit *git-changelog* be configured permanently via config files.

Resolves: pawamoy#54.
oesteban added a commit to oesteban/git-changelog that referenced this issue Aug 18, 2023
Permit *git-changelog* be configured permanently via config files.

Resolves: pawamoy#54.
oesteban added a commit to oesteban/git-changelog that referenced this issue Aug 18, 2023
Permit *git-changelog* be configured permanently via config files.

Resolves: pawamoy#54.
oesteban added a commit to oesteban/git-changelog that referenced this issue Aug 18, 2023
Permit *git-changelog* be configured permanently via config files.

Resolves: pawamoy#54.
oesteban added a commit to oesteban/git-changelog that referenced this issue Aug 21, 2023
Permit *git-changelog* be configured permanently via config files.

Resolves: pawamoy#54.
pawamoy pushed a commit that referenced this issue Aug 22, 2023
Issue #54: #54
PR #55: #55
Co-authored-by: Timothée Mazzucotelli <pawamoy@pm.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants