Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using 'npm start' for dev, indicate to developer that they also need to run rendezvous server #258

Open
jimpick opened this issue Dec 4, 2018 · 4 comments

Comments

@jimpick
Copy link
Member

jimpick commented Dec 4, 2018

With PR #253, we now configure peer-pad to use a rendezvous server running on localhost when the developer runs npm start. If the developer doesn't read the documentation, they might not know that they need to also run npm run start:rendezvous ... if they don't the application prevents editing, and it's not really obvious what is happening.

In #253, we discussed either running the rendezvous server automatically, or indicating to the user that they need to run it themselves.

@parkan
Copy link
Collaborator

parkan commented Dec 4, 2018

what happens is that the binding fails and the node silently fails to start, right?

this in itself is kind of broken (libp2p/js-libp2p-websocket-star#61), you should generally be able to use the app in single-player mode, especially for development, though right now making that happen unfortunately requires fixing js-libp2p

@pgte
Copy link
Collaborator

pgte commented Dec 5, 2018

Running peer-pad from local rendezvous-vous would require injecting some alternative configuration into peer-pad in compile or pre-boot-run-time.

@parkan
Copy link
Collaborator

parkan commented Dec 5, 2018

@pgte does this not accomplish that? #253

@pgte
Copy link
Collaborator

pgte commented Dec 5, 2018

@parkan it does, nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants