Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the development runtime #80

Closed
TorstenStueber opened this issue Nov 30, 2022 · 6 comments · Fixed by #428
Closed

Remove the development runtime #80

TorstenStueber opened this issue Nov 30, 2022 · 6 comments · Fixed by #428
Assignees

Comments

@TorstenStueber
Copy link
Member

TorstenStueber commented Nov 30, 2022

Feedback from SBP Milestone 3 review: The development runtime name is a bit misleading, as it seems that this is not merely a runtime for developers to use locally, but the Pendulum runtime intended for future deployment on Polkadot.

New Description

Let us just remove the development runtime all together.

@vadaynujra
Copy link

@ebma
Copy link
Member

ebma commented Jul 25, 2023

@TorstenStueber would you consider this ticket still relevant? Maybe we should remove the development runtime altogether as we never used it.

@b-yap
Copy link
Contributor

b-yap commented Jul 26, 2023

would you consider this ticket still relevant? Maybe we should remove the development runtime altogether as we never used it.

I agree.

@TorstenStueber
Copy link
Member Author

TorstenStueber commented Jul 26, 2023

Yes, I don't even remember why it is there and think that we never use it. I think I/we originally intended it to be a standalone version of Foucoco/Amplitude/Pendulum to make it easy to run relevant components locally. But with Zombienet that would not be necessary anymore.

I changed the description of the ticket.

@ebma ebma changed the title Change the name of the development runtime Remove the development runtime Feb 7, 2024
@bogdanS98
Copy link
Contributor

Aside from the reasons mentioned above, there are 2 more reasons why this should be removed:

  • Being able to successfully run the pipeline tests with feature flags as described here
  • Freeing some space for the workflow job since we already are at the limit. No need to compile a runtime that is never used.

@ebma
Copy link
Member

ebma commented Feb 22, 2024

Agreed, this is nice to have and very low effort. I'll move it out of the icebox and into the 'ready' column because implementing this should be quick @pendulum-chain/product.

@bogdanS98 bogdanS98 self-assigned this Feb 23, 2024
@b-yap b-yap self-assigned this Feb 26, 2024
@b-yap b-yap closed this as completed in #428 Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants