fix(wifibox): avoid race conditions on restarting the guest
#125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ppt` driver cannot be cleared until the VM runs so move the respective `devctl(8)` call back to the end of `destroy_vm`. Restore the wait period after the VM is destroyed to make sure that the device is released. More importantly, do not let `vm_stop` to call `destroy_vm` but leave it the VM manager to take care of the clean-up tasks. The VM manager should be unblocked to do that after the guest either stops by itself (due to the ACPI power-off event) or forcefully stopped. In addition to that, wait for the VM manager to stop too, because it should not be launched again (on a different thread) until all the clean-up tasks have been completed.
pgj
force-pushed
the
fix/wifibox/races_on_restart
branch
from
77d8494
to
3d6cb5b
Compare
pgj
added a commit
to pgj/freebsd-wifibox-port
that referenced
this pull request
Sep 27, 2024
pgj
added a commit
to pgj/freebsd-wifibox-port
that referenced
this pull request
Sep 27, 2024
pgj
added a commit
to pgj/freebsd-wifibox-port
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pptdriver cannot be cleared until the VM runs so move the respectivedevctl(8)call back to the end ofdestroy_vm. Restore the wait period after the VM is destroyed to make sure that the device is released.More importantly, do not let
vm_stopto calldestroy_vmbut leave it the VM manager to take care of the clean-up tasks. The VM manager should be unblocked to do that after the guest either stops by itself (due to the ACPI power-off event) or forcefully stopped. In addition to that, wait for the VM manager to stop too, because it should not be launched again (on a different thread) until all the clean-up tasks have been completed.