Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"args is not defined" in tab_operations.js when executing bookmarklet #4334

Closed
joobus opened this issue Oct 13, 2023 · 2 comments
Closed

"args is not defined" in tab_operations.js when executing bookmarklet #4334

joobus opened this issue Oct 13, 2023 · 2 comments

Comments

@joobus
Copy link

joobus commented Oct 13, 2023

Describe the bug

When executing a bookmarklet I am getting the error:

Uncaught (in promise) ReferenceError: args is not defined
    at openUrlInCurrentTab (tab_operations.js:36:7)
    at main.js:667:36
    at async utils.js:378:24

Link to offending line. Possibly you meant scriptingArgs.world = "MAIN"?

I'm not sure if this is related to this. I checked the site's content policy and it didn't seem restrictive.

To Reproduce

Steps to reproduce the behavior:

  1. Go to URL 'https://www.zerohedge.com/geopolitical/israel-gives-11-million-gazans-24-hours-evacuate-northern-strip-hamas-says-ignore'
  2. Execute this bookmarklet via the vomnibar:
javascript:window.location.href="https://talk.zerohedge.com/embed/stream?asset_url="+window.location.href;

args-not-defined-vimium

Browser and Vimium version

Brave: 1.60.89 Chromium: 118.0.5993.70 (Official Build) beta (64-bit)

Vimium: 2.0.2

@joobus joobus changed the title "arg not defined" in tab_operation.js when executing bookmarklet "args is not defined" in tab_operation.js when executing bookmarklet Oct 13, 2023
@joobus joobus changed the title "args is not defined" in tab_operation.js when executing bookmarklet "args is not defined" in tab_operations.js when executing bookmarklet Oct 13, 2023
@joobus
Copy link
Author

joobus commented Oct 13, 2023

Possibly you meant scriptingArgs.world = "MAIN" here?

@philc philc closed this as completed in 912f3c6 Oct 15, 2023
@philc
Copy link
Owner

philc commented Oct 15, 2023

That is embarrassing 😠. Thank you @joobus for the detailed report. I'll push this out as a new version tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants