From cd1ea0e9bea1fec4bf87bb4ed80b12bd296730cf Mon Sep 17 00:00:00 2001 From: jrfnl Date: Wed, 27 Mar 2024 18:24:43 +0100 Subject: [PATCH] GH Actions: run tests also on Windows OS When running the tests locally, I realized that patch 146 did not actually work correctly on Windows. This commit adds test runs against Windows in CI on a limited number of PHP versions to prevent this kind of issue going unnoticed for future PRs. --- .github/workflows/test.yml | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 5157fba..999baf5 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -92,7 +92,7 @@ jobs: test: name: Run tests on PHP ${{ matrix.php }} - runs-on: ubuntu-latest + runs-on: "${{ matrix.os }}" continue-on-error: ${{ matrix.php == '8.4' }} needs: - bundle @@ -114,6 +114,19 @@ jobs: - '8.2' - '8.3' - '8.4' + os: + - 'ubuntu-latest' + + include: + # Also run the tests against Windows on a few PHP versions. + - php: '5.3' + os: 'windows-latest' + - php: '7.0' + os: 'windows-latest' + - php: '8.0' + os: 'windows-latest' + - php: '8.3' + os: 'windows-latest' steps: - name: Checkout code