Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP support #258

Closed
niutech opened this issue Aug 18, 2017 · 8 comments
Closed

AMP support #258

niutech opened this issue Aug 18, 2017 · 8 comments

Comments

@niutech
Copy link

niutech commented Aug 18, 2017

Spectre could be compatible with AMP by slightly modifying the code: removing !important, replacing <img> with <amp-img> and removing inline style="" from HTML. I made the AMP components page demo: https://repl.it/KPR2/3 or fullscreen: http://s.cssdeck.com/labs/full/x5pjudqw/noframe

Would you like to add an official AMP flavor of the Spectre CSS framework?

@krlklm
Copy link

krlklm commented Aug 24, 2017

Why i would not promote AMP:

https://daringfireball.net/linked/2017/05/20/gilbertson-amp

@niutech
Copy link
Author

niutech commented Aug 24, 2017

I don't get that hatred for AMP. Of course one can make a performant website without it, but in the real life almost all companies bloat their websites. AMP is a radical step to forbid web bloat and stick to lightweight solutions. It really improves loading web pages, you can try it on desktop using my AMP Browser.

@picturepan2
Copy link
Owner

@niutech I will not add an AMP flavor.

@niutech
Copy link
Author

niutech commented Mar 29, 2018

Finally I have made an AMP version of your framework: https://github.com/niutech/amp-spectre/

@AdsonCicilioti
Copy link

AdsonCicilioti commented May 16, 2018

@niutech , Did you generate this version using an original fork? I mean the source files Sass, gulpfile.js, etc?
@picturepan2 could you express your opinion on why you should not pay attention to the AMP?

@leeoniya
Copy link

@niutech
Copy link
Author

niutech commented May 16, 2018

@AdsonCicilioti I generated AMP Spectre using this file: https://github.com/picturepan2/spectre/blob/master/dist/spectre.min.css
@leeoniya AMP v0.js is only 78.4 KB gzipped and it's served from the CDN, so it's downloaded only once for all AMP pages.

@AdsonCicilioti
Copy link

@niutech, the show/hide layout utility class din't work on elements with display:flex, like as navbar-sections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants