Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop down doesn't work on safari on IOS #263

Closed
Jped opened this issue Aug 28, 2017 · 7 comments
Closed

drop down doesn't work on safari on IOS #263

Jped opened this issue Aug 28, 2017 · 7 comments
Assignees
Labels

Comments

@Jped
Copy link

Jped commented Aug 28, 2017

I have a dropdown on the mobile version of themorningmunch.com (you have to sign in to see it)

The dropdown button doesnt work with IOS. I have tested it on my android phone and it does work
I have read online that there are similar problems to this on bootstrap, is there any solution for spectre?

here is the code for the dropdown

  <div class="dropdown">
              <button  style="margin-right:10px" href="#" class="btn dropdown-toggle" tabindex="0">
                  <i class="icon icon-more-vert"></i>
              </button>
        <!-- menu component -->
              <ul class="menu" style="text-align:center">
                <li><a href="/viewMunch">Your&nbsp;MM </a></li>
                <li><a href="/editOrder"><span class="lg-view"> Edit Order of feeds</span><span class="sm-view">Edit Order</span></a></li>
                <li><a href="/munches#emailModal">Email Preferences</a></li>
              </ul>
            </div>
@picturepan2
Copy link
Owner

@Jped button can NOT be focused even with tabindex. Use a instead.

@Jped
Copy link
Author

Jped commented Aug 29, 2017

@picturepan2 Thanks for a quick response! That fixes the issue, but now the dropdown doesnt close, is there a way to get it close when hitting the link again?

@green3g
Copy link

green3g commented Aug 29, 2017

Clicking the link again won't change the focused state of the link (which controls the visibility). You'd probably have to do a little javascript to get a truly toggle-able dropdown.

@picturepan2
Copy link
Owner

picturepan2 commented Aug 29, 2017

@Jped Javascript is better with the component. But you can add a clickable mask element to focus another target, as Spectre Docs does it with the mask below to close the sidebar in the mobile.

<a href="#sidebar-close" id="sidebar-close" class="docs-nav-clear"></a>

@ezzdev
Copy link

ezzdev commented Sep 16, 2017

@picturepan2 Same issue here i am using a tag still not working

even in documentation the dropdown button not working too check it with Safari on IOS

https://picturepan2.github.io/spectre/components.html#menus

@jloh
Copy link

jloh commented May 1, 2018

I'm running into this now as well. When clicking off a dropdown in iOS the dropdown doesn't disappear.

@natxocc
Copy link

natxocc commented May 18, 2018

Me too. IOS 10.3. Dropdown doesn't disappear clicking outside dropdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants