Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar does not close properly in IE11 #275

Closed
Potentiator opened this issue Sep 6, 2017 · 8 comments
Closed

Sidebar does not close properly in IE11 #275

Potentiator opened this issue Sep 6, 2017 · 8 comments

Comments

@Potentiator
Copy link

First, I just want to say great work! This framework looks pretty awesome, and will be using for a project soon.

Second, I found an issue with the sidebar menu items not closing properly in IE11 when the window is resized (for the docs page). It works fine in Chrome and MS Edge. The accordion component is a little flaky in IE11 as well with the visibility of the menu items when expanded.

Will you be releasing this as a component (Sidebar)? I could proabably extract what I need, but it would be great to have this as a standalone (perhaps with Icons).

Thanks!

@picturepan2
Copy link
Owner

picturepan2 commented Sep 6, 2017

@Potentiator I will test it in IE11 and see what bug it is. Thank you.

Do you mean releasing the off-screen sidebar as a component?

@Potentiator
Copy link
Author

Potentiator commented Sep 6, 2017

@picturepan2 Great - thanks!

Yes, releasing the off-screen sidebar as a component would be useful. I can probably figure it out from the docs though, so not a big issue for me.

@cMurschall
Copy link

I second the idea of releasing an off-screen sidebar as a component!

@picturepan2
Copy link
Owner

@Potentiator The bug in IE11 is fixed in v0.4.1 which is still in dev.

@Potentiator
Copy link
Author

@picturepan2 Thanks!

@picturepan2
Copy link
Owner

picturepan2 commented Sep 11, 2017

@Potentiator Released https://picturepan2.github.io/spectre/

@Potentiator
Copy link
Author

@picturepan2 Awesome - appreciate the quick turnaround on this one.

@picturepan2
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants