Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-moz-appearance missing #381

Closed
Vectrex opened this issue Jan 15, 2018 · 5 comments
Closed

-moz-appearance missing #381

Vectrex opened this issue Jan 15, 2018 · 5 comments

Comments

@Vectrex
Copy link

Vectrex commented Jan 15, 2018

Whilst the form element examples on https://picturepan2.github.io have the namespaced Mozilla properties set, they are missing in the repository version. A select element on Firefox therefore still shows the stock drop-down arrow.

@picturepan2
Copy link
Owner

@Vectrex Checking.

@picturepan2
Copy link
Owner

@Vectrex I have checked and all are fine. What do you mean by "the repository version"?

@Vectrex
Copy link
Author

Vectrex commented Jan 16, 2018

Looking at the select in
https://picturepan2.github.io/spectre/elements.html#forms
the resulting rule according to the web development tools reads

.form-select {
    -webkit-appearance: none;
    -moz-appearance: none;
    appearance: none;
    border: .05rem solid #caced7;
    border-radius: .1rem;
    color: inherit;
    font-size: .8rem;
    height: 1.8rem;
    line-height: 1rem;
    outline: none;
    padding: .35rem .4rem;
        padding-right: 0.4rem;
    vertical-align: middle;
    width: 100%;
}

I can find this rule set in the dist file, but the scss files which I use to combine Spectre.css with my customizations (just pulled from the repo) don't create a "moz"-prefixed property and searching through all scss files in the src folder for "-appearance" results in

Searching 73 files for "-appearance"

src/_normalize.scss:
  281  [type="reset"],
  282  [type="submit"] {
  283:   -webkit-appearance: button; /* 2 */
  284  }
  285  
  ...
  371  
  372  [type="search"] {
  373:   -webkit-appearance: textfield; /* 1 */
  374    outline-offset: -2px; /* 2 */
  375  }
  ...
  381  [type="search"]::-webkit-search-cancel-button,
  382  [type="search"]::-webkit-search-decoration {
  383:   -webkit-appearance: none;
  384  }
  385  
  ...
  390  
  391  ::-webkit-file-upload-button {
  392:   -webkit-appearance: button; /* 1 */
  393    font: inherit; /* 2 */
  394  }

src/_sliders.scss:
   21    // Slider Thumb
   22    &::-webkit-slider-thumb {
   23:     -webkit-appearance: none;
   24      background: $primary-color;
   25      border: 0;

5 matches across 2 files

Searching for "-appearance" in the result file yields five matches, all with a "-webkit" prefix and none addressing a select element.
The scss file to build this resulting CSS file:

$primary-color: #0089CC;
$secondary-color: #FF9400;
$base-font-family: "verbcond";

@import "spectre/spectre";
@import "spectre/spectre-exp";
@import "spectre/spectre-icons";

.nav-item {
  & > span {
    padding: $unit-1 $unit-2;
  }
  &.active > span {
    font-weight: bold;
  }
}
...

@picturepan2
Copy link
Owner

@Vectrex What is your gulp pipeline rules for your custom code?

@Vectrex
Copy link
Author

Vectrex commented Jan 16, 2018

Oookay. That explains it. Since I only use the scss builder in my IDE I miss out on the autoprefixer, which presumably care about the prefixing. Sorry for the hassle.

@Vectrex Vectrex closed this as completed Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants