Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables should not add thick border bottom to th when inside tbody #447

Closed
kurthamilton opened this issue May 31, 2018 · 3 comments
Closed
Labels

Comments

@kurthamilton
Copy link

Feature
Header row has thick border bottom applied via .table th selector.

Problem
This does not differentiate between th elements in the thead and the tbody.

Example

Col 1 Col 2
Row 1 cell cell
Row 2 cell cell

where table has a table class applied.

I would want to retain the bold styling for Row 1 and Row 2 th elements, but not have a partial thick border bottom.

Suggested fix
Style border bottom with .table thead th selector instead of .table th.

@picturepan2
Copy link
Owner

@kurthamilton It is not a problem. The table cells in thead are th. Only th has thicker bottom border.

@kurthamilton
Copy link
Author

My point is that you can have 2 types of th:
table > thead > tr > th
table > tbody > tr > th

A thick border bottom is added to both by targeting th. Normal tbody rows have a thin border bottom.

When you have a th in a tbody row, only the th has a thick border bottom. In my opinion this is undesirable and a bug.

I shall continue to fix with an override of
.table > tbody > tr > th {
border-bottom-width: $border-width;
}

@kurthamilton
Copy link
Author

Here's a fiddle to demonstrate:
https://jsfiddle.net/p1kfsw45/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants