Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nir_convert_df_to_long removes nan values #100

Open
JGuetschow opened this issue Mar 23, 2022 · 0 comments
Open

nir_convert_df_to_long removes nan values #100

JGuetschow opened this issue Mar 23, 2022 · 0 comments
Assignees
Labels
bug Something isn't working priority: high High priority issue: prioritize and solve as soon as possible priority: medium medium priority issue. Good to solve soon if possible

Comments

@JGuetschow
Copy link
Contributor

Describe the bug
Currently the function primap2.pm2io.nir_convert_df_to_long removes values interpreted as nan. This included e.g. the string "NA". This contradicts the option to specify a mapping to nan and 0 when converting the data to primap2 format. Thus this should be changed for consistency reasons.

Expected behavior

Keep nan values, so mapping can be made explicit

It is easy to fix, just add 'dropna=False' to the stack command in line 167 of _GHG_inventory_reading.py.

Additional context

It's not worth it's own branch an pull request so the issue is just a reminder to fix this with the next set of changes.

@JGuetschow JGuetschow added the bug Something isn't working label Mar 23, 2022
@JGuetschow JGuetschow self-assigned this Mar 23, 2022
@JGuetschow JGuetschow added priority: high High priority issue: prioritize and solve as soon as possible priority: medium medium priority issue. Good to solve soon if possible labels Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: high High priority issue: prioritize and solve as soon as possible priority: medium medium priority issue. Good to solve soon if possible
Projects
None yet
Development

No branches or pull requests

1 participant