Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fully type everything and add py.typed marker #189

Open
mikapfl opened this issue Dec 22, 2023 · 1 comment
Open

fully type everything and add py.typed marker #189

mikapfl opened this issue Dec 22, 2023 · 1 comment

Comments

@mikapfl
Copy link
Member

mikapfl commented Dec 22, 2023

Is your feature request related to a problem? Please describe.

If you import primap2 in a file and check the file with mypy, you get an error:

app.py:1: error: Skipping analyzing "primap2": module is installed, but missing library stubs or py.typed marker  [import]

That's of course stupid because primap2 is in fact typed, we just haven't added the correct marker to tell the world about it.

Describe the solution you'd like

Add the py.typed marker file.

Additional context

I'm unfortunately not sure what will happen with the xarray accessor and if typing works on it. May have to investigate.

@mikapfl
Copy link
Member Author

mikapfl commented Mar 26, 2024

Actually, we are not mypy-clean, so we need to put the work in to fix all remaining mypy issues before we can add the py.typed marker.

@mikapfl mikapfl changed the title add py.typed marker fully type everything and add py.typed marker Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant