Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV reading with non-comma separators #210

Open
JGuetschow opened this issue Apr 5, 2024 · 4 comments
Open

CSV reading with non-comma separators #210

JGuetschow opened this issue Apr 5, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@JGuetschow
Copy link
Contributor

Is your feature request related to a problem? Please describe.

When reading data from csv files, only files with comma as separator can be read using the read...csv_file_if functions as the sep parameter in pd.read_csv can not be specified

Describe the solution you'd like

Add the sep parameter to primap2 csv reading routines

Describe alternatives you've considered

Read csv using pandas function and convert in a second thep

@JGuetschow JGuetschow added the enhancement New feature or request label Apr 5, 2024
@JGuetschow JGuetschow self-assigned this Apr 5, 2024
@JGuetschow JGuetschow changed the title Data reading improvement CSV reading with non-comma separators Apr 5, 2024
@mikapfl
Copy link
Member

mikapfl commented Apr 5, 2024

Read csv using pandas function and convert in a second thep

Might actually be worth, the API surface of pd.read_csv is huge and next thing we probably want to read from database or something, which pandas can do, but we don't have a function. So, I'd say: just use pandas' reading functions, then convert_long_dataframe_if.

@JGuetschow
Copy link
Contributor Author

I do that all the time. At some point we might remove the csv reading functions as they can basically never be used

@mikapfl
Copy link
Member

mikapfl commented Apr 5, 2024

Yeah, I think reading the interchange format with a specific function has value, but in general so-called CSVs are super diverse. Probably it was not realistic to expect them to be sufficiently well-formed to read them with one function. /-:

@JGuetschow
Copy link
Contributor Author

I think we can close this as we decided not to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants