From 9b465f26d1dc50b29fb517ceacc236b6985bc208 Mon Sep 17 00:00:00 2001 From: Lonng Date: Wed, 8 May 2019 13:36:30 +0800 Subject: [PATCH] Apply suggestions from code review Co-Authored-By: kennytm --- tools/lightning/deployment.md | 2 +- tools/lightning/errors.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/lightning/deployment.md b/tools/lightning/deployment.md index 0f2d3faf1f218..2c62da6ec4cb3 100644 --- a/tools/lightning/deployment.md +++ b/tools/lightning/deployment.md @@ -238,7 +238,7 @@ Download the TiDB-Lightning package (choose the same version as that of the TiDB # Maximum number of open engines. max-open-engines = 8 # Maximum upload speed (bytes per second) from Importer to TiKV. - upload-speed-limit = "512MB" + #upload-speed-limit = "512MB" # minimum ratio of target store available space: store_available_space / store_capacity. # Importer pauses uploading SST if the availability ratio of the target store is less than this # value, to give PD enough time to balance regions. diff --git a/tools/lightning/errors.md b/tools/lightning/errors.md index 8a03c5a676557..9e7d15ca7a2f6 100644 --- a/tools/lightning/errors.md +++ b/tools/lightning/errors.md @@ -77,9 +77,9 @@ See the [Checkpoints control](../../tools/lightning/checkpoints.md#checkpoints-c Max Memory Usage ≈ `max-open-engine` × `write-buffer-size` × `max-write-buffer-number` -2. Decrease the value of `table-concurrency` + `index-concurrency` so it is less than `max-open-engine`. +2. Decrease the value of `table-concurrency` + `index-concurrency` so it is less than `max-open-engines`. -3. Restart `tikv-importer` to forcefully remove all engine files. This also removes all partially imported tables, thus it is required to clear the outdated checkpoints. +3. Restart `tikv-importer` to forcefully remove all engine files (default to `./data.import/`). This also removes all partially imported tables, thus it is required to clear the outdated checkpoints. ```sh tidb-lightning-ctl --config conf/tidb-lightning.toml --checkpoint-error-destroy=all