Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

date and time functions are not totally MySQL compatible #7455

Closed
zhangyangyu opened this issue Jan 23, 2022 · 2 comments · Fixed by #7468
Closed

date and time functions are not totally MySQL compatible #7455

zhangyangyu opened this issue Jan 23, 2022 · 2 comments · Fixed by #7468
Assignees
@morgo
Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. type/bugfix This PR fixes a bug.

Comments

@zhangyangyu
Copy link
Member

Error Report

Please answer the following questions before submitting your issue. Thanks!

  1. What is the URL/path of the document related to this issue?

https://docs.pingcap.com/tidb/stable/date-and-time-functions#date-and-time-functions

  1. How would you like to improve it?

Currently the date and time functions page directly links to MySQL docs. But there are still some specifiers not supported yet, see pingcap/tidb#30082. Gives a wrong feeling to readers that all are supported.
@TomShawn TomShawn added area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. type/bugfix This PR fixes a bug. labels Jan 24, 2022
@TomShawn
Copy link
Contributor

@morgo @XuHuaiyu Could you please take a look? Can we describe the unsupported specifiers? Thanks~

@morgo morgo self-assigned this Jan 24, 2022
@morgo
Copy link
Contributor

morgo commented Jan 24, 2022

Yes, I can take a look. Independent of the unsupported specifiers, I think it's also important to add some language to describe that date+time compatibility with MySQL is very difficult with invalid dates.

@morgo morgo mentioned this issue Jan 24, 2022
Merged
14 tasks
This was referenced Apr 14, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@morgo morgo

Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add notes on datetime morgo/docs
3 participants
@morgo @zhangyangyu @TomShawn