Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCP: support AutoSclaerRef for TidbCluster #2484

Closed
Yisaer opened this issue May 18, 2020 · 5 comments · Fixed by #2791
Closed

UCP: support AutoSclaerRef for TidbCluster #2484

Yisaer opened this issue May 18, 2020 · 5 comments · Fixed by #2791
Assignees
Labels
area/auto-scaling related to auto-scaling challenge-program-2 difficulty/medium status/WIP Issue/PR is being worked on

Comments

@Yisaer
Copy link
Contributor

Yisaer commented May 18, 2020

Description

Currently, 1 tidbcluster could be controlled by multi TidbclusterAutoScaler which is not we want. We need 1 tidbcluster should be controlled by no more than 1 TidbclusterAutoScaler.

To achieve this purpose, We want to add a new attribute in TidbCluster Status and named as AutoSclaerRef.

The AutoSclaerRef would be kind like mutex that the TidbclusterAutoScaler should first patch itself to the target Tidbcluster's AutoSclaerRef. If success, it would start to sync the auto-scaler procss for the target tidbcluster. If not success, it just only skip the current syncing.

The controller logic is much more similar as MonitorRef, you can know the reference from this pr. #2424

Score

  • 400

Mentor(s)

Contact the mentors: #tidb-challenge-program channel in TiDB-Operator Community Slack Workspace
As the logic is not simple and the detail is still needed to be discussed, we are welcome for every challenger to contact the mentor if you have any questions.

Recommended Skills

  • Golang
  • Kubernetes
@Yisaer Yisaer added the area/auto-scaling related to auto-scaling label May 18, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 18, 2020

@PengJi don't have enough score, pick up failed

Progress 0/200
You may pick up some easy issues first

1 similar comment
@sre-bot
Copy link
Contributor

sre-bot commented May 18, 2020

@PengJi don't have enough score, pick up failed

Progress 0/200
You may pick up some easy issues first

@Yisaer
Copy link
Contributor Author

Yisaer commented May 19, 2020

@PengJi assign the challenge to you, take your time.

@PengJi
Copy link
Contributor

PengJi commented May 19, 2020

@Yisaer OK,I'm interested in it

@cofyc cofyc added the status/WIP Issue/PR is being worked on label Jun 8, 2020
@Yisaer
Copy link
Contributor Author

Yisaer commented Jun 22, 2020

@PengJi Hi, this feature is important to Auto-scaling, so I'm going to realize this feature myself as it seems haven't any progress now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/auto-scaling related to auto-scaling challenge-program-2 difficulty/medium status/WIP Issue/PR is being worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants