Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set terminationGracePeriodSeconds and lifecycle to all controllers #2847

Open
weekface opened this issue Jul 1, 2020 · 4 comments
Open

set terminationGracePeriodSeconds and lifecycle to all controllers #2847

weekface opened this issue Jul 1, 2020 · 4 comments

Comments

@weekface
Copy link
Contributor

weekface commented Jul 1, 2020

follow: #2810 (comment)

@weekface weekface self-assigned this Jul 1, 2020
@cofyc cofyc added the status/WIP Issue/PR is being worked on label Jul 1, 2020
@DanielZhangQD DanielZhangQD modified the milestone: v1.1.4 Jul 27, 2020
@DanielZhangQD DanielZhangQD added Hacktoberfest and removed status/WIP Issue/PR is being worked on labels Oct 9, 2020
@namco1992
Copy link
Contributor

@weekface @DanielZhangQD From what I saw here:

if a.TerminationGracePeriodSeconds() != nil {
It's handled by the BuildPodSpec already, may I ask what else needs to be done?

@DanielZhangQD
Copy link
Contributor

@namco1992

  • The controller for Pump does not call the BuildPodSpec function
  • The lifecycle is now only added for TiDB

@namco1992
Copy link
Contributor

@DanielZhangQD ok, then I can take a look on this issue.

@DanielZhangQD
Copy link
Contributor

@DanielZhangQD ok, then I can take a look on this issue.

@namco1992 OK, thanks!
And you can also check if any other issues you're interested in as I think this issue does not address any requirement from any users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants