From c48a5203566d086b90e923681c936a29359d07fe Mon Sep 17 00:00:00 2001 From: Weizhen Wang Date: Sat, 25 Jun 2022 17:59:07 +0800 Subject: [PATCH] fix --- br/pkg/storage/azblob.go | 2 ++ br/pkg/storage/gcs.go | 1 + br/pkg/storage/writer.go | 1 + 3 files changed, 4 insertions(+) diff --git a/br/pkg/storage/azblob.go b/br/pkg/storage/azblob.go index 08f25cbe06bf1..7b4bb9a477525 100644 --- a/br/pkg/storage/azblob.go +++ b/br/pkg/storage/azblob.go @@ -273,6 +273,7 @@ func (s *AzureBlobStorage) WriteFile(ctx context.Context, name string, data []by if err != nil { return errors.Annotatef(err, "Failed to write azure blob file, file info: bucket(container)='%s', key='%s'", s.options.Bucket, s.withPrefix(name)) } + //nolint: errcheck defer resp.Body.Close() return nil } @@ -283,6 +284,7 @@ func (s *AzureBlobStorage) ReadFile(ctx context.Context, name string) ([]byte, e if err != nil { return nil, errors.Annotatef(err, "Failed to download azure blob file, file info: bucket(container)='%s', key='%s'", s.options.Bucket, s.withPrefix(name)) } + //nolint: errcheck defer resp.RawResponse.Body.Close() data, err := io.ReadAll(resp.Body(azblob.RetryReaderOptions{})) if err != nil { diff --git a/br/pkg/storage/gcs.go b/br/pkg/storage/gcs.go index abecab4362c74..10eaba324628f 100644 --- a/br/pkg/storage/gcs.go +++ b/br/pkg/storage/gcs.go @@ -128,6 +128,7 @@ func (s *gcsStorage) ReadFile(ctx context.Context, name string) ([]byte, error) "failed to read gcs file, file info: input.bucket='%s', input.key='%s'", s.gcs.Bucket, object) } + //nolint: errcheck defer rc.Close() size := rc.Attrs.Size diff --git a/br/pkg/storage/writer.go b/br/pkg/storage/writer.go index e029b553952c2..fceb43436cfe9 100644 --- a/br/pkg/storage/writer.go +++ b/br/pkg/storage/writer.go @@ -159,6 +159,7 @@ func (u *bufferedWriter) Write(ctx context.Context, p []byte) (int, error) { continue } } + //nolint: errcheck u.buf.Flush() err := u.uploadChunk(ctx) if err != nil {