From dbd61c9873dc9dfb4233c86654a5f0e00c33b3e9 Mon Sep 17 00:00:00 2001
From: pingcap-github-bot <sre-bot@pingcap.com>
Date: Mon, 21 Oct 2019 21:28:51 +0800
Subject: [PATCH] metrics: add index speed metric (#12374) (#12390)

---
 ddl/index.go       | 3 +++
 metrics/ddl.go     | 8 ++++++++
 metrics/metrics.go | 1 +
 3 files changed, 12 insertions(+)

diff --git a/ddl/index.go b/ddl/index.go
index 1c12f35ef5341..e3fc94fba1d18 100644
--- a/ddl/index.go
+++ b/ddl/index.go
@@ -894,6 +894,8 @@ func (w *addIndexWorker) backfillIndexInTxn(handleRange reorgIndexTask) (taskCtx
 	return
 }
 
+var addIndexSpeedCounter = metrics.AddIndexTotalCounter.WithLabelValues("speed")
+
 // handleBackfillTask backfills range [task.startHandle, task.endHandle) handle's index to table.
 func (w *addIndexWorker) handleBackfillTask(d *ddlCtx, task *reorgIndexTask) *addIndexResult {
 	handleRange := *task
@@ -919,6 +921,7 @@ func (w *addIndexWorker) handleBackfillTask(d *ddlCtx, task *reorgIndexTask) *ad
 			return result
 		}
 
+		addIndexSpeedCounter.Add(float64(taskCtx.addedCount))
 		mergeAddIndexCtxToResult(&taskCtx, result)
 		w.ddlWorker.reorgCtx.increaseRowCount(int64(taskCtx.addedCount))
 
diff --git a/metrics/ddl.go b/metrics/ddl.go
index 92de5826c6d8c..e36f58bd7b1f3 100644
--- a/metrics/ddl.go
+++ b/metrics/ddl.go
@@ -105,6 +105,14 @@ var (
 			Name:      "worker_operation_total",
 			Help:      "Counter of creating ddl/worker and isowner.",
 		}, []string{LblType})
+
+	AddIndexTotalCounter = prometheus.NewCounterVec(
+		prometheus.CounterOpts{
+			Namespace: "tidb",
+			Subsystem: "ddl",
+			Name:      "add_index_total",
+			Help:      "Speed of add index",
+		}, []string{LblType})
 )
 
 // Label constants.
diff --git a/metrics/metrics.go b/metrics/metrics.go
index 60efda0a1df28..74805734e9679 100644
--- a/metrics/metrics.go
+++ b/metrics/metrics.go
@@ -70,6 +70,7 @@ func RegisterMetrics() {
 	prometheus.MustRegister(PreparedStmtGauge)
 	prometheus.MustRegister(CriticalErrorCounter)
 	prometheus.MustRegister(DDLCounter)
+	prometheus.MustRegister(AddIndexTotalCounter)
 	prometheus.MustRegister(DDLWorkerHistogram)
 	prometheus.MustRegister(DeploySyncerHistogram)
 	prometheus.MustRegister(DistSQLPartialCountHistogram)