Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize transaction commits to avoid them failed caused by DDL execution #18098

Closed
3 tasks
scsldb opened this issue Jun 17, 2020 · 3 comments
Closed
3 tasks
Assignees
Labels
feature/accepted This feature request is accepted by product managers priority/P0 The issue has P0 priority. type/feature-request Categorizes issue or PR as related to a new feature. type/usability
Milestone

Comments

@scsldb
Copy link

scsldb commented Jun 17, 2020

Description

Optimized the pessimistic transaction model when the DDL and DML were executed at the same time, the system error problem, improved the stability of the system

Category

Usability

Value

In the database pessimistic locking mode, the execution of DDL will affect the execution of DML, and the execution of DML transactions will fail. When it fails, it will output "mode has changed" or "table does not exist" error message, but DDL truncates the table/deletes. The impact of the table is minimal.

We expect that DDL execution will not affect the DML transaction execution and improve the ease of use of the system. The recommended solution is to automatically input the DML and DDL statements that are being executed when the error is found. At the same time, after waiting for a period of time, if the retry is still unsuccessful, then output the error message or Must block execution. Please pay attention to maintain compatibility with tools such as pt-online when implementing this solution.

Task List

  • ADD/DROP Columns doesn't affect transaction.
  • ADD/DROP Indexes doesn't affect transaction.
  • Change/Modify Columns doesn't affect transaction.

Workload Estimation

30

Time

GanttStart: 2020-07-01
GanttDue: 2020-09-04
GanttProgress: 100%

@scsldb scsldb added type/feature-request Categorizes issue or PR as related to a new feature. priority/P0 The issue has P0 priority. labels Jun 17, 2020
@scsldb scsldb added this to the v5.0-alpha milestone Jun 17, 2020
@cfzjywxk
Copy link
Contributor

cfzjywxk commented Jul 3, 2020

@scsldb scsldb changed the title DDL affects DML execution in pessimistic lock mode Optimized the pessimistic transaction model when the DDL and DML were executed at the same time, the system error problem, improved the stability of the system Jul 16, 2020
@jackysp jackysp changed the title Optimized the pessimistic transaction model when the DDL and DML were executed at the same time, the system error problem, improved the stability of the system Optimize transaction commits to avoid them failed caused by DDL execution Jul 27, 2020
@zz-jason zz-jason added the feature/accepted This feature request is accepted by product managers label Jul 29, 2020
@uglyengineer
Copy link

finish date postponed 2 times, from 7/30 to 8/21 and then to 9/04

@zz-jason
Copy link
Member

close due to the project is finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/accepted This feature request is accepted by product managers priority/P0 The issue has P0 priority. type/feature-request Categorizes issue or PR as related to a new feature. type/usability
Projects
None yet
Development

No branches or pull requests

5 participants