Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The point get executor and batch point get executor may not be thread safe #19130

Open
cfzjywxk opened this issue Aug 11, 2020 · 3 comments
Open
Labels
challenge-program component/executor help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/execution SIG execution type/question The issue belongs to a question.

Comments

@cfzjywxk
Copy link
Contributor

cfzjywxk commented Aug 11, 2020

Description

Bug Report

Please answer these questions before submitting your issue. Thanks!

Issue #16817 says

I guess there may exist other problems / panics behind this single symptom described in this issue, because PointGet now may be
 running in parallel with other goroutines(not only the main goroutine in this case, but other goroutines, e.g, workers of IndexJoin 
/ IndexHashJoin?), while the original implementation of its execution seems not to consider the possibility of concurrent running?
 We'd better do a full check of these potential concurrent situations to make sure PointGet is safe there.

For batchPointGetExecutor, the init flag is set using atomic operations, but the index field is not. Maybe we need to do more checks and tests to ensure these two executors are thread-safe.

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

SIG slack channel

#sig-exec

Score

300

Mentor

@cfzjywxk cfzjywxk added type/bug The issue is confirmed as a bug. component/executor labels Aug 11, 2020
@fzhedu fzhedu self-assigned this Aug 25, 2020
@ichn-hu
Copy link
Contributor

ichn-hu commented Sep 16, 2020

/unassign @fzhedu

@ichn-hu
Copy link
Contributor

ichn-hu commented Sep 16, 2020

/assign @ichn-hu

@ichn-hu
Copy link
Contributor

ichn-hu commented Nov 23, 2020

/unassign @ichn-hu

@lzmhhh123 lzmhhh123 added challenge-program help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/question The issue belongs to a question. and removed type/bug The issue is confirmed as a bug. labels Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
challenge-program component/executor help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/execution SIG execution type/question The issue belongs to a question.
Projects
None yet
Development

No branches or pull requests

6 participants