unstable test testSuite1.TestAnalyzeFullSamplingOnIndexWithVirtualColumnOrPrefixColumn

[zhouqiang-cl]

Bug Report

[2021-06-08T10:07:12.122Z] ----------------------------------------------------------------------
[2021-06-08T10:07:12.122Z] FAIL: analyze_test.go:985: testSuite1.TestAnalyzeFullSamplingOnIndexWithVirtualColumnOrPrefixColumn
[2021-06-08T10:07:12.122Z] 
[2021-06-08T10:07:12.122Z] analyze_test.go:992:
[2021-06-08T10:07:12.122Z]     tk.MustExec("analyze table sampling_index_virtual_col with 1 topn")
[2021-06-08T10:07:12.122Z] /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:217:
[2021-06-08T10:07:12.122Z]     tk.c.Assert(err, check.IsNil, check.Commentf("sql:%s, %v, error stack %v", sql, args, errors.ErrorStack(err)))
[2021-06-08T10:07:12.122Z] ... value *errors.fundamental = analyze worker panic ("analyze worker panic")
[2021-06-08T10:07:12.122Z] ... sql:analyze table sampling_index_virtual_col with 1 topn, [], error stack analyze worker panic
[2021-06-08T10:07:12.122Z] github.com/pingcap/tidb/executor.init
[2021-06-08T10:07:12.122Z] 	/home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/executor/analyze.go:247
[2021-06-08T10:07:12.122Z] runtime.doInit
[2021-06-08T10:07:12.122Z] 	/usr/local/go/src/runtime/proc.go:6309
[2021-06-08T10:07:12.122Z] runtime.doInit
[2021-06-08T10:07:12.122Z] 	/usr/local/go/src/runtime/proc.go:6286
[2021-06-08T10:07:12.122Z] runtime.main
[2021-06-08T10:07:12.122Z] 	/usr/local/go/src/runtime/proc.go:208
[2021-06-08T10:07:12.122Z] runtime.goexit
[2021-06-08T10:07:12.122Z] 	/usr/local/go/src/runtime/asm_amd64.s:1371
[2021-06-08T10:07:12.122Z] 

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

in ci https://ci.pingcap.net/blue/rest/organizations/jenkins/pipelines/tidb-unit-test-nightly/runs/258/nodes/133/steps/563/log/?start=0

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

master 7538818

[winoros]

It's strange that from the log we see

goroutine 30022 [running]:
github.com/pingcap/tidb/executor.(*AnalyzeColumnsExec).subBuildWorker.func1(0xc07218ed20, 0xc070c9e900, 0x0)
\t/home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/executor/analyze.go:1237 +0x105
panic(0x3579b00, 0x3fc7b20)
\t/usr/local/go/src/runtime/panic.go:965 +0x1b9
github.com/pingcap/tidb/executor.(*AnalyzeColumnsExec).subBuildWorker(0xc070c9e900, 0xc07218ed20, 0xc07218ed80, 0xc071651d70, 0x3, 0x3, 0xc071651d88, 0x3, 0x3, 0xc071651dd0, ...)
\t/home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/executor/analyze.go:1250 +0x1531
created by github.com/pingcap/tidb/executor.(*AnalyzeColumnsExec).buildSamplingStats
\t/home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/executor/analyze.go:938 +0x11d2

The line 1250 is

	failpoint.Inject("mockAnalyzeSamplingBuildWorkerPanic", func() {
		panic("failpoint triggered")
	})

The failpoint panicked when we don't want it to be panicked.

[qw4990]

https://ci.pingcap.net/blue/rest/organizations/jenkins/pipelines/tidb_ghpr_unit_test/runs/5484/nodes/93/steps/176/log/?start=0 +1

[bb7133]

Very likely that it has been fixed by #25547, since the stack looks the same and it doesn't reproduce for weeks.

Close this issue.

[ti-srebot]

Please edit this comment or add a new comment to complete the following information

Not a bug

1. Remove the 'type/bug' label
2. Add notes to indicate why it is not a bug

Duplicate bug

1. Add the 'type/duplicate' label
2. Add the link to the original bug

Bug

Note: Make Sure that 'component', and 'severity' labels are added
Example for how to fill out the template: #20100

1. Root Cause Analysis (RCA) (optional)

2. Symptom (optional)

3. All Trigger Conditions (optional)

4. Workaround (optional)

5. Affected versions

6. Fixed versions