Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

untable test testSuiteWithData.TestRangePartitionBoundariesEq #25395

Closed
Tracked by #25899
zhouqiang-cl opened this issue Jun 14, 2021 · 6 comments
Closed
Tracked by #25899

untable test testSuiteWithData.TestRangePartitionBoundariesEq #25395

zhouqiang-cl opened this issue Jun 14, 2021 · 6 comments
Assignees
Labels
severity/major sig/planner SIG: Planner type/bug The issue is confirmed as a bug.

Comments

@zhouqiang-cl
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

[2021-06-14T10:15:57.674Z] 
[2021-06-14T10:15:57.674Z] ----------------------------------------------------------------------
[2021-06-14T10:15:57.674Z] FAIL: partition_table_test.go:2619: testSuiteWithData.TestRangePartitionBoundariesEq
[2021-06-14T10:15:57.674Z] 
[2021-06-14T10:15:57.674Z] partition_table_test.go:2638:
[2021-06-14T10:15:57.674Z]     s.verifyPartitionResult(tk, input, output)
[2021-06-14T10:15:57.674Z] /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:217:
[2021-06-14T10:15:57.674Z]     tk.c.Assert(err, check.IsNil, check.Commentf("sql:%s, %v, error stack %v", sql, args, errors.ErrorStack(err)))
[2021-06-14T10:15:57.674Z] ... value *errors.fundamental = analyze worker panic ("analyze worker panic")
[2021-06-14T10:15:57.674Z] ... sql:ANALYZE TABLE t, [], error stack analyze worker panic
[2021-06-14T10:15:57.674Z] github.com/pingcap/tidb/executor.init
[2021-06-14T10:15:57.674Z] 	/home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/executor/analyze.go:247
[2021-06-14T10:15:57.674Z] runtime.doInit
[2021-06-14T10:15:57.674Z] 	/usr/local/go/src/runtime/proc.go:6309
[2021-06-14T10:15:57.674Z] runtime.doInit
[2021-06-14T10:15:57.674Z] 	/usr/local/go/src/runtime/proc.go:6286
[2021-06-14T10:15:57.674Z] runtime.main
[2021-06-14T10:15:57.674Z] 	/usr/local/go/src/runtime/proc.go:208
[2021-06-14T10:15:57.674Z] runtime.goexit
[2021-06-14T10:15:57.674Z] 	/usr/local/go/src/runtime/asm_amd64.s:1371

1. Minimal reproduce step (Required)

in ci https://ci.pingcap.net/blue/rest/organizations/jenkins/pipelines/tidb-unit-test-nightly/runs/624/nodes/104/steps/318/log/?start=0

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

master a45b3aa

@zhouqiang-cl zhouqiang-cl added the type/bug The issue is confirmed as a bug. label Jun 14, 2021
@mjonss
Copy link
Contributor

mjonss commented Jun 18, 2021

Looks similar to #25269. Probably not unstable test, but a real bug in ANALYZE TABLE for partitioned tables?

@zimulala
Copy link
Contributor

@mjonss
So would you like someone to help to investigate this? Or is it a problem you're interested in dealing with?

@mjonss
Copy link
Contributor

mjonss commented Jul 22, 2021

@zimulala Yes please, since this points to an issue with ANALYZE TABLE, not the test it self:

sql:ANALYZE TABLE t, [], error stack analyze worker panic

Btw are there anywhere I can find statistics of failed tests over time?

@mjonss
Copy link
Contributor

mjonss commented Jul 24, 2021

I have tried to reproduce the issue with current master a4146033fb6deec464de9faf5f5412b87ef5d06c without success.
I ran the unit tests in executor directory 100 times with random overlap/concurrent runs. Could it be that it was an issue with ANALYZE TABLE that has been an issue before, but has been fixed since this unstable test was reported?

@bb7133
Copy link
Member

bb7133 commented Jul 26, 2021

Very likely that it has been fixed by #25547, since the stack looks the same and it doesn't reproduce for several weeks.

Close this issue.

@bb7133 bb7133 closed this as completed Jul 26, 2021
@ti-srebot
Copy link
Contributor

Please edit this comment or add a new comment to complete the following information

Not a bug

  1. Remove the 'type/bug' label
  2. Add notes to indicate why it is not a bug

Duplicate bug

  1. Add the 'type/duplicate' label
  2. Add the link to the original bug

Bug

Note: Make Sure that 'component', and 'severity' labels are added
Example for how to fill out the template: #20100

1. Root Cause Analysis (RCA) (optional)

2. Symptom (optional)

3. All Trigger Conditions (optional)

4. Workaround (optional)

5. Affected versions

6. Fixed versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/major sig/planner SIG: Planner type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

6 participants