Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more sql_mode #2738

Closed
shenli opened this issue Feb 26, 2017 · 2 comments
Closed

Support more sql_mode #2738

shenli opened this issue Feb 26, 2017 · 2 comments
Labels
type/compatibility

Comments

@shenli
Copy link
Member

shenli commented Feb 26, 2017

SQL_Mode is important in MySQL. We should handle more modes, for example 'ANSI_QUOTES'.
See https://dev.mysql.com/doc/refman/5.7/en/sql-mode.html
@shenli shenli added the todo label Feb 26, 2017
@shenli shenli mentioned this issue Feb 26, 2017
Merged
@morgo morgo mentioned this issue Sep 7, 2018
Closed
@morgo morgo mentioned this issue Nov 11, 2018
Closed
@morgo
Copy link
Contributor

morgo commented Nov 11, 2018

Every sql_mode is supported except the deprecated modes, with one exception: ALLOW_INVALID_DATES. I suggest that we add it just so we can say we have full compatibility.

@morgo
Copy link
Contributor

morgo commented Nov 26, 2018

There is now a dedicated issue for ALLOW_INVALID_DATES, so I am going to close this issue now.

Please feel free to re-open if you have any followup questions. Thanks!

@morgo morgo closed this as completed Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@morgo @shenli @zimulala