Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system variables which default value changed should use new default value after upgrade #41423

Closed
seiya-annie opened this issue Feb 15, 2023 · 0 comments · Fixed by #41424
Closed
Labels
affects-6.6 severity/major type/bug The issue is confirmed as a bug.

Comments

@seiya-annie
Copy link

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

if use not config these system variable, default value should be new value after upgrade.
foreign_key_checks= old:'OFF' new: 'ON'
tidb_enable_foreign_key= old:'OFF' new: 'ON'
tidb_enable_historical_stats= old:'OFF' new: 'ON'
tidb_enable_plan_replayer_capture= old:'OFF' new: 'ON'
tidb_store_batch_size= old:'0' new: '4'

2. What did you expect to see? (Required)

default value should be same with new scratch cluster

3. What did you see instead (Required)

still use old default value

4. What is your TiDB version? (Required)

v6.6.0-pre

@seiya-annie seiya-annie added the type/bug The issue is confirmed as a bug. label Feb 15, 2023
@ti-chi-bot ti-chi-bot added may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.0 may-affects-6.1 may-affects-6.2 may-affects-6.3 may-affects-6.4 may-affects-6.5 labels Feb 15, 2023
@you06 you06 removed may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-6.0 may-affects-6.1 may-affects-6.2 may-affects-6.3 may-affects-6.4 may-affects-6.5 labels Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.6 severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants