Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HashJoinExec.Close should wait for the exit of innerWorker #7611

Closed
XuHuaiyu opened this issue Sep 4, 2018 · 1 comment
Closed

HashJoinExec.Close should wait for the exit of innerWorker #7611

XuHuaiyu opened this issue Sep 4, 2018 · 1 comment
Labels
sig/execution SIG execution type/bug The issue is confirmed as a bug.

Comments

@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Sep 4, 2018

After, #6856 the inner data fetcher and outer data fetcher will run
simultaneously. If an error happens during fetching the outer table data,
HashJoinExec.Close will be called, but the inner data fetcher may be still
running at this time. Some unexpected error may be raised due to this such
as data race. So, the inner data fetcher should exit in time if there is an
error found in outer data fetcher, and HashJoinExec.Close should wait for
the exit of inner data fetcher.

@XuHuaiyu XuHuaiyu added type/bug The issue is confirmed as a bug. sig/execution SIG execution labels Sep 4, 2018
@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Sep 4, 2018

Fix in #7554

@XuHuaiyu XuHuaiyu closed this as completed Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

1 participant