Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NO_AUTO_CREATE_USER sql_mode #8128

Closed
morgo opened this issue Oct 31, 2018 · 0 comments · Fixed by #8160
Closed

Support NO_AUTO_CREATE_USER sql_mode #8128

morgo opened this issue Oct 31, 2018 · 0 comments · Fixed by #8160
Assignees
Labels
component/privilege good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. type/compatibility

Comments

@morgo
Copy link
Contributor

morgo commented Oct 31, 2018

Feature Request

Is your feature request related to a problem? Please describe:

Currently the sql-mode NO_AUTO_CREATE_USER is parsed but ignored. This mode is important, since the MySQL permission model is otherwise vulnerable to spelling errors causing unathenticated users to have admin privileges. Consider the following hypothetical case:

-- A new user joins an organization, and is given read only access
CREATE USER 'morgantocker' IDENTIFIED BY 'sekret';
GRANT SELECT ON *.* TO 'morgantocker';

-- Time elapses.
-- The user is then given admin privileges by the organization:
GRANT ALL ON *.* TO 'morgantucker';

-- But there was a common spelling error, 'morgantucker' instead of 'morgantocker' !
-- This leads to a really bad situation, a new user is created with `ALL` and no password!

Describe the feature you'd like:

The sql_mode NO_AUTO_CREATE_USER, to be enabled by default (next GA) as it is in MySQL.

Describe alternatives you've considered:

N/A

Teachability, Documentation, Adoption, Migration Strategy:

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/privilege good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. type/compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants