From 0a073c89f013b200c6b1b5b7756dace076c5e9b2 Mon Sep 17 00:00:00 2001 From: crazycs520 Date: Wed, 25 Sep 2019 13:03:31 +0800 Subject: [PATCH] ddl: add index speed metric --- ddl/index.go | 3 +++ metrics/ddl.go | 8 ++++++++ metrics/metrics.go | 1 + 3 files changed, 12 insertions(+) diff --git a/ddl/index.go b/ddl/index.go index ce57552494417..ec644a3bfcd52 100644 --- a/ddl/index.go +++ b/ddl/index.go @@ -804,6 +804,8 @@ func (w *addIndexWorker) backfillIndexInTxn(handleRange reorgIndexTask) (taskCtx return } +var addIndexSpeedCounter = metrics.AddIndexTotalCounter.WithLabelValues("speed") + // handleBackfillTask backfills range [task.startHandle, task.endHandle) handle's index to table. func (w *addIndexWorker) handleBackfillTask(d *ddlCtx, task *reorgIndexTask) *addIndexResult { handleRange := *task @@ -825,6 +827,7 @@ func (w *addIndexWorker) handleBackfillTask(d *ddlCtx, task *reorgIndexTask) *ad return result } + addIndexSpeedCounter.Add(float64(taskCtx.addedCount)) mergeAddIndexCtxToResult(&taskCtx, result) w.ddlWorker.reorgCtx.increaseRowCount(int64(taskCtx.addedCount)) diff --git a/metrics/ddl.go b/metrics/ddl.go index 2ffcde005b99b..40c047719f197 100644 --- a/metrics/ddl.go +++ b/metrics/ddl.go @@ -105,6 +105,14 @@ var ( Name: "worker_operation_total", Help: "Counter of creating ddl/worker and isowner.", }, []string{LblType}) + + AddIndexTotalCounter = prometheus.NewCounterVec( + prometheus.CounterOpts{ + Namespace: "tidb", + Subsystem: "ddl", + Name: "add_index_total", + Help: "Speed of add index", + }, []string{LblType}) ) // Label constants. diff --git a/metrics/metrics.go b/metrics/metrics.go index 69b04ad3abaf6..4265beba49b5f 100644 --- a/metrics/metrics.go +++ b/metrics/metrics.go @@ -59,6 +59,7 @@ func RegisterMetrics() { prometheus.MustRegister(ConnGauge) prometheus.MustRegister(CriticalErrorCounter) prometheus.MustRegister(DDLCounter) + prometheus.MustRegister(AddIndexTotalCounter) prometheus.MustRegister(DDLWorkerHistogram) prometheus.MustRegister(DeploySyncerHistogram) prometheus.MustRegister(DistSQLPartialCountHistogram)