From f8dec0ebb38c18e46ebd9d877d004093215a6a6c Mon Sep 17 00:00:00 2001 From: Weizhen Wang Date: Thu, 14 Mar 2024 18:58:22 +0800 Subject: [PATCH] server: fix data race in the TestProxyProtocolWithIpNoFallbackable Signed-off-by: Weizhen Wang --- pkg/server/tests/commontest/tidb_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/server/tests/commontest/tidb_test.go b/pkg/server/tests/commontest/tidb_test.go index dccefb05c262f..617274d6d39dc 100644 --- a/pkg/server/tests/commontest/tidb_test.go +++ b/pkg/server/tests/commontest/tidb_test.go @@ -2959,6 +2959,7 @@ func TestProxyProtocolWithIpNoFallbackable(t *testing.T) { ts := servertestkit.CreateTidbTestSuite(t) // Prepare Server + server2.RunInGoTestChan = make(chan struct{}) server, err := server2.NewServer(cfg, ts.Tidbdrv) require.NoError(t, err) server.SetDomain(ts.Domain) @@ -2966,7 +2967,7 @@ func TestProxyProtocolWithIpNoFallbackable(t *testing.T) { err := server.Run(nil) require.NoError(t, err) }() - time.Sleep(time.Millisecond * 1000) + <-server2.RunInGoTestChan defer func() { server.Close() }()