Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ssh LDAP extension #528

Closed
lucklove opened this issue Jun 23, 2020 · 3 comments · Fixed by #615
Closed

Support ssh LDAP extension #528

lucklove opened this issue Jun 23, 2020 · 3 comments · Fixed by #615
Assignees
@lucklove
Labels
priority/P0 Indicates that the priority of a issue is very high. type/feature-request Categorizes issue as related to a new feature.
Milestone
v1.1.0

Comments

@lucklove
Copy link
Member

lucklove commented Jun 23, 2020 •
edited
Loading

Feature Request

Is your feature request related to a problem? Please describe:

At current we only support standard ssh tunnel. However, some people/companies use LDAP as the extension of ssh to manage their machines, in this case, tiup will not work. So they can't upgrade their cluster to v4 since tidb-ansible don't support tidb v4 and tiup can't work in their case.

DevProgress: 100%
QAProgress: 30%
DocProgress: 100%

GanttStart: 2020-07-20
GanttDue: 2020-08-10
GanttProgress: 100%
@lucklove lucklove added the type/enhancement Categorizes issue or PR as related to an enhancement. label Jun 23, 2020
@lonng lonng added the status/TODO Categorizes issue as we will do it. label Jun 24, 2020
@lucklove lucklove added this to the v1.1.0 milestone Jun 28, 2020
@AstroProfundis AstroProfundis added type/feature-request Categorizes issue as related to a new feature. and removed type/enhancement Categorizes issue or PR as related to an enhancement. labels Jul 7, 2020
@AstroProfundis AstroProfundis self-assigned this Jul 7, 2020
@lucklove lucklove added the priority/P0 Indicates that the priority of a issue is very high. label Jul 14, 2020
@uglyengineer
Copy link

Issues belong to 5.0/P0 need to have start/end date. Please reveal the dates.

@lucklove
Copy link
Member Author

Issues belong to 5.0/P0 need to have start/end date. Please reveal the dates.

Done

@lonng lonng linked a pull request Jul 20, 2020 that will close this issue
Support native ssh client #615
Merged
15 tasks
@AstroProfundis AstroProfundis removed the status/TODO Categorizes issue as we will do it. label Jul 27, 2020
@IANTHEREAL IANTHEREAL reopened this Jul 28, 2020
@AstroProfundis
Copy link
Contributor

We need to set default value of -i and -p to empty for native (system) SSH executor, to let the ssh command really being able to invoke whatever extended authentication method available.

In this circumstance, it's better to implement #693 as the argument style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucklove lucklove

Labels
priority/P0 Indicates that the priority of a issue is very high. type/feature-request Categorizes issue as related to a new feature.
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

Support native ssh client lucklove/tiup
5 participants
@AstroProfundis @lonng @lucklove @IANTHEREAL @uglyengineer