-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove User Gesture popup modal on Sidebar #9165
Comments
Adding "specification required flag" because, as per the discussions/proposal we don't have a technical workaround for this. So it needs clarification before engineering picks it up One option that has been floated is to open the sidebar on all tabs (i.e., keep it globally open) to avoid having to reopen it. But that solution may not be suitable Another option would be to re-add support for an embedded sidebar (aka MV2 sidebar) to better support these use cases |
@mthek10 would either of the workarounds that Todd mentioned^ suffice in the meantime? @twschiller can you share documentation so I can read up on the MV2 embedded sidebar? |
The MV2 sidebar isn't a Chrome affordance. It was a sidebar we implemented. It injects a frame into the page and attempts (sometimes unsuccessfully, due to absolute element positioning) to shift the main content over You can find videos of the old behavior on our YouTube channel: https://www.youtube.com/watch?v=iL7IXGFt1Ys |
Next steps: @Pashaminkovsky to sync w/ @mthek10 on what we can do here |
For the decision tree/quality/compliance use cases in question, one approach we might take is modifying the "Display Temporary Information" brick to be able to show the panel in an embedded sidebar. That embedded sidebar could be like the modal and only contain the panel content and not the mod launcher, etc. That could get around the engineering concern of having to maintain 2 completely different sidebar protocols, as we could just use the existing modal code but change how the iframe is added to the page |
MV3 requires a user gesture before opening the sidepanel. This is causing friction with a number of use cases (e.g. compliance).
This was available in MV2 but broke in MV3. Are there any workarounds to the user gesture requirement that we can implement?
Relevant discussions:
The text was updated successfully, but these errors were encountered: