Do not upload release packages to apt automatically

Summary:
Jenkins automatically triggers upload of new debian packages for
openMHA releases to our apt repository.

But because we still need to check that all installers function after
they have been created, this is too early.

Remove this automatism and provide a way to trigger it manually after
checks.

Closes T1117

Test Plan: Will be tested today during release. Review before the release.

Reviewers: pmaanen, MaxZ

Reviewed By: MaxZ

Maniphest Tasks: T1117

Differential Revision: https://dev.openmha.org/D493

Jenkinsfile

@@ -200,8 +200,17 @@ pipeline {
         }
         stage("debian packages for apt") {
             agent {label "aptly"}
-            // do not publish packages for any branches except these
-            when { anyOf { branch 'master'; branch 'development' } }
+            // publish packages for branch development automatically
+            when { branch 'development' }
+
+            // Releases are not automatically uploaded to apt because
+            // we still need to check that all installers function
+            // after they have been created. When this verification has
+            // been done, then start a Replay build of master on Jenkins,
+            // and change this Jenkinsfile as follows: comment-out the "when"
+            // line above, remove the comment before the following "when"
+            // line, and then Run the replay build.
+            // when { anyOf { branch 'master'; branch 'development' } }
             steps {
                 // receive all deb packages from openmha build
                 unstash "x86_64_bionic"

mha/tools/release.sh

@@ -153,6 +153,12 @@ fi
 echo "Now the mac and windows installers need to be attached to the github release."
 echo "Answer yes when finished."
 ask_yes_no
+echo "Now the Linux installers need to be published to our apt repository."
+echo "Open Jenkins in webbrowser, navigate to the last openMHA master branch build,"
+echo "select replay, then search in the Jenkinsfile for the comment containing"
+echo '"Releases are not automatically" ... and follow the instructions in this comment.'
+echo "Answer yes when finished."
+ask_yes_no
 
 if $dry_run
 then