Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs elementor/frontend/after_register_styles possibly wrong? #1992

Closed
stratboy opened this issue Jul 11, 2017 · 1 comment
Closed

Docs elementor/frontend/after_register_styles possibly wrong? #1992

stratboy opened this issue Jul 11, 2017 · 1 comment

Comments

@stratboy
Copy link
Contributor

stratboy commented Jul 11, 2017

Hi, on the docs of elementor/frontend/after_register_styles, I can read this code:

add_action( 'elementor/frontend/after_register_styles', function() {
   wp_dequeue_style( 'font-awesome' );
});

Usually, wp_dequeue_style is used after enqueueing styles, not after registering. So maybe you should write wp_deregister_style or change filter to elementor/frontend/after_enqueue_styles.
I would have done the edit, but I'm no sure if this code is somewhat related to elementor's internals.

Anyway, docs also lacks 'elementor/frontend/after_enqueue_styles'. They're not complete for scripts hooks too.

@KingYes
Copy link
Member

KingYes commented Jul 11, 2017

Thanks!

@KingYes KingYes closed this as completed Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants