From c03e760238bd792f6ad02a40282ed3617dd1e478 Mon Sep 17 00:00:00 2001 From: squnit <46118980+squnit@users.noreply.github.com> Date: Mon, 2 Sep 2024 03:21:58 -0400 Subject: [PATCH] refactor(rust): Allow polars to pass cargo check on windows (#18498) --- .gitignore | 1 + crates/polars-io/src/mmap.rs | 13 ++++++++++--- crates/polars-python/src/file.rs | 4 +++- crates/polars-utils/src/mem.rs | 4 ++-- 4 files changed, 16 insertions(+), 6 deletions(-) diff --git a/.gitignore b/.gitignore index 3c03000ed764..6cb7cc6fa0bd 100644 --- a/.gitignore +++ b/.gitignore @@ -1,5 +1,6 @@ *.iml *.so +*.pyd *.ipynb .ENV .env diff --git a/crates/polars-io/src/mmap.rs b/crates/polars-io/src/mmap.rs index 73dd48498f51..66ea8ed7b48b 100644 --- a/crates/polars-io/src/mmap.rs +++ b/crates/polars-io/src/mmap.rs @@ -1,13 +1,20 @@ +#[cfg(target_family = "unix")] use std::collections::btree_map::Entry; +#[cfg(target_family = "unix")] use std::collections::BTreeMap; use std::fs::File; use std::io::{BufReader, Cursor, Read, Seek}; -use std::sync::{Arc, Mutex}; +use std::sync::Arc; +#[cfg(target_family = "unix")] +use std::sync::Mutex; use memmap::Mmap; +#[cfg(target_family = "unix")] use once_cell::sync::Lazy; use polars_core::config::verbose; -use polars_error::{polars_bail, PolarsResult}; +#[cfg(target_family = "unix")] +use polars_error::polars_bail; +use polars_error::PolarsResult; use polars_utils::mmap::MemSlice; // Keep track of memory mapped files so we don't write to them while reading @@ -60,7 +67,7 @@ impl Drop for MMapSemaphore { } } -pub fn ensure_not_mapped(file: &File) -> PolarsResult<()> { +pub fn ensure_not_mapped(#[allow(unused)] file: &File) -> PolarsResult<()> { #[cfg(target_family = "unix")] { use std::os::unix::fs::MetadataExt; diff --git a/crates/polars-python/src/file.rs b/crates/polars-python/src/file.rs index 93494eeea179..bcdfd7ff6ee7 100644 --- a/crates/polars-python/src/file.rs +++ b/crates/polars-python/src/file.rs @@ -1,5 +1,7 @@ use std::borrow::Cow; -use std::fs::{self, File}; +#[cfg(target_family = "unix")] +use std::fs; +use std::fs::File; use std::io; use std::io::{Cursor, ErrorKind, Read, Seek, SeekFrom, Write}; #[cfg(target_family = "unix")] diff --git a/crates/polars-utils/src/mem.rs b/crates/polars-utils/src/mem.rs index 8462d1a57538..4fee5b842f63 100644 --- a/crates/polars-utils/src/mem.rs +++ b/crates/polars-utils/src/mem.rs @@ -54,13 +54,13 @@ pub fn prefetch_l2(slice: &[u8]) { } /// `madvise()` with `MADV_SEQUENTIAL` on unix systems. This is a no-op on non-unix systems. -pub fn madvise_sequential(slice: &[u8]) { +pub fn madvise_sequential(#[allow(unused)] slice: &[u8]) { #[cfg(target_family = "unix")] madvise(slice, libc::MADV_SEQUENTIAL); } /// `madvise()` with `MADV_WILLNEED` on unix systems. This is a no-op on non-unix systems. -pub fn madvise_willneed(slice: &[u8]) { +pub fn madvise_willneed(#[allow(unused)] slice: &[u8]) { #[cfg(target_family = "unix")] madvise(slice, libc::MADV_WILLNEED); }