Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation for floordiv #14614

Closed
orlp opened this issue Feb 20, 2024 · 0 comments · Fixed by #16054
Closed

Improve documentation for floordiv #14614

orlp opened this issue Feb 20, 2024 · 0 comments · Fixed by #16054
Labels
A-arithmetic Area: arithmetic accepted Ready for implementation documentation Improvements or additions to documentation

Comments

@orlp
Copy link
Collaborator

orlp commented Feb 20, 2024

For floating point numbers our flooring division is defined as floor(x / y), or floor(x * (1/y)) for scalar y, see here for context and rationale.

This subtly differs in behavior from Python's floating point // division. Our documentation should reflect that.
@orlp orlp added documentation Improvements or additions to documentation accepted Ready for implementation A-arithmetic Area: arithmetic labels Feb 20, 2024
@bertiewooster bertiewooster mentioned this issue May 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-arithmetic Area: arithmetic accepted Ready for implementation documentation Improvements or additions to documentation
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(python): Explain how Polars floor division differs from Python bertiewooster/polars
1 participant
@orlp