Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polywrap.build.yaml - allow developer to use a custom polywrap-build.sh script #1335

Open
dOrgJelli opened this issue Oct 17, 2022 · 2 comments · May be fixed by #1370
Open

polywrap.build.yaml - allow developer to use a custom polywrap-build.sh script #1335

dOrgJelli opened this issue Oct 17, 2022 · 2 comments · May be fixed by #1370
Assignees
@dOrgJelli
Labels
flag: blocker pri: high type: feature-proposal
Milestone
golden-path

Comments

@dOrgJelli
Copy link
Member

Is your feature request related to a problem? Please describe.
When developers are building wasm wrappers with the vm build strategy, the only way to customize it is to modify the build script located at .polywrap/wasm/build/project/polywrap-build.sh directory, and run the docker command manually.

Describe the solution you'd like
Developers should be able to set the build script within the build manifest, something similar to this:

strategies:
  vm:
    build_script: ./custom.sh
@dOrgJelli dOrgJelli added this to the origin-qa milestone Oct 17, 2022
@dOrgJelli
Copy link
Member Author

This has been reported as a required feature by one of our users, who needs to pass in a "prod" environment variables at build-time.

@dOrgJelli dOrgJelli self-assigned this Oct 29, 2022
@dOrgJelli
Copy link
Member Author

I've started work on this, will push shortly.

@dOrgJelli dOrgJelli linked a pull request Oct 29, 2022 that will close this issue
Draft
@dOrgJelli dOrgJelli modified the milestones: origin-qa, golden-path Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dOrgJelli dOrgJelli

Labels
flag: blocker pri: high type: feature-proposal
Projects
None yet
Milestone
golden-path
Development

Successfully merging a pull request may close this issue.

feat: Build Manifest 0.3.0 polywrap/wrap-cli
1 participant
@dOrgJelli