Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R: Diagnostics crash related to passing tree sitter nodes back and forth with R #2630

Closed
DavisVaughan opened this issue Apr 3, 2024 · 1 comment
Labels
area: diagnostics Issues related to Diagnostics area: kernels Issues related to Jupyter kernels and LSP servers bug Something isn't working lang: r

Comments

@DavisVaughan
Copy link
Contributor

library(abind, package = )

Just put that code in an editor, it should crash immediately. I see something like:

Screen.Recording.2024-04-03.at.2.19.36.PM.mov
Likely caused by: Error: RAW() can only be applied to a 'raw', not a 'NULL'

this error is pretty telling, as there is only one real place we use RAW(), and thats when we pass the raw tree sitter node back and forth with R.

I think it is coming from here, where I think node here is NULL
https://github.com/posit-dev/amalthea/blob/dc47a8f671521dcc1e17f0d3f67ea5d5b6493a29/crates/ark/src/modules/positron/diagnostics.R#L49-L51

I think the matched call here really does have NULL as the package = arg
https://github.com/posit-dev/amalthea/blob/dc47a8f671521dcc1e17f0d3f67ea5d5b6493a29/crates/ark/src/modules/positron/diagnostics.R#L86-L92

@DavisVaughan DavisVaughan added bug Something isn't working lang: r labels Apr 3, 2024
@DavisVaughan DavisVaughan added this to the Release Candidate milestone Apr 3, 2024
@lionel- lionel- added area: kernels Issues related to Jupyter kernels and LSP servers area: diagnostics Issues related to Diagnostics labels May 16, 2024
@lionel-
Copy link
Contributor

lionel- commented Aug 28, 2024

We have removed the offending code a while ago.

@lionel- lionel- closed this as completed Aug 28, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: diagnostics Issues related to Diagnostics area: kernels Issues related to Jupyter kernels and LSP servers bug Something isn't working lang: r
Projects
None yet
Development

No branches or pull requests

2 participants