Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: conform PPResume to PWA Builder stage 1 #47

Closed
Tracked by #37
xiaohanyu opened this issue May 13, 2024 · 2 comments
Closed
Tracked by #37

feat: conform PPResume to PWA Builder stage 1 #47

xiaohanyu opened this issue May 13, 2024 · 2 comments
Assignees
@xiaohanyu
Labels
feat New feature or request frontend Frontend related
Milestone
M-0.5

Comments

@xiaohanyu
Copy link
Member

xiaohanyu commented May 13, 2024 •
edited
Loading

Description

PWA Builder showed us a list of suggestions to further improve PPResume's manifest. Let's revise the manifest to conform PPResume to PWA Builder's suggestions as much as possible.

image

[Optional] Possible Solutions

NA

Acceptance Criteria

  • try best to conform PWA Builder's manifest checker's suggestions

Todo list

NA
@xiaohanyu xiaohanyu mentioned this issue May 13, 2024
Closed
@xiaohanyu xiaohanyu self-assigned this May 13, 2024
@xiaohanyu xiaohanyu added feat New feature or request frontend Frontend related labels May 13, 2024
@xiaohanyu xiaohanyu added this to the M-0.5 milestone May 13, 2024
@xiaohanyu
Copy link
Member Author

xiaohanyu commented May 13, 2024 •
edited
Loading

If theme_color is not specified, chrome and edge would show different font color.

Chrome:

  • light mode:
image
  • dark mode:
image

Edge:

  • light mode:
image
  • dark mode:
image

And theme_color do not support dark/light mode switch yet, check this issue

It seems possible to change theme_color dynamically via JavaScript, though.

@xiaohanyu
Copy link
Member Author

xiaohanyu commented May 13, 2024 •
edited
Loading

Before fix we have 15 warnings, after fix we have 8 warnings, we will create other issues to further improve PPResume PWA

image

@xiaohanyu xiaohanyu changed the title feat: conform PPResume to PWA Builder feat: conform PPResume to PWA Builder stage 1 May 15, 2024
@xiaohanyu xiaohanyu mentioned this issue Jul 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiaohanyu xiaohanyu

Labels
feat New feature or request frontend Frontend related
Projects
None yet
Milestone
M-0.5
Development

No branches or pull requests
1 participant
@xiaohanyu