-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve log API #19
Comments
W/ Putting the data object as a json encoded string in the
looks good!
perhaps drop the |
What do we know about constraints on the error object in the |
It's just sent as a VM protocol reference - you can then call service protocol methods to get more info about it. From the client, you basically just see the vm service protocol id for the object ( |
#20 adds data logging but we'll want to keep iterating. food for thought from @devoncarew on that PR:
👍 |
We should hammer out what we minimally need for 1.0. #38 adds params to allow for passing of What else (if anything) do we need for v1? /cc @devoncarew |
Follow-up from #16 (comment), minimally we should add:
toEncodable
callback (if we want to rely on json encodeability for data objects, we should have an optional convert param for LogMessageCallback #10)logError
anddata
objects@devoncarew: would 2 calls be sufficient?:
Or do you think there's benefit in making a distinction between
log
andlogData
?The text was updated successfully, but these errors were encountered: