Commits

Branch selector

 master

User selector

All users

All time

Commit History

Commits on Apr 24, 2024

• Tweak some permalinks to use #kebab-case instead of #snake_case or #nospacingatall.

  

  code-health-devguide-copybara

  authored and

  Copybara-Service

  committedApr 24, 2024
  fde5fd4

Commits on Mar 26, 2024

• Add examples of minor suggestions to the "LGTM With Comments" section.

  

  kluever

  authored and

  Copybara-Service

  committedMar 26, 2024
  a54db24

Commits on Dec 4, 2023

• Emphasize that tests are expected by default.

  

  code-health-devguide-copybara

  authored and

  Copybara-Service

  committedDec 4, 2023
  82e7d4b

Commits on Nov 30, 2023

• No public description

  

  code-health-devguide-copybara

  authored and

  Copybara-Service

  committedNov 30, 2023
  6846311

Commits on Nov 23, 2023

• First, "rpc" is an acronym, so it should be capitalized. Second, we demand first line be a "complete sentence", so it should start with a capital letter.

  

  code-health-devguide-copybara

  authored and

  Copybara-Service

  committedNov 23, 2023
  27bbdae

Commits on Jul 17, 2023

• Fixed annotation for code-health-devguide-copybara to pick up correct file contents in small-cls

  

  code-health-devguide-copybara

  authored and

  Copybara-Service

  committedJul 17, 2023
  f59560f

Commits on Jul 14, 2023

• Add more guidance and benefits of planning out and writing self-contained CLs.

  

  code-health-devguide-copybara

  authored and

  Copybara-Service

  committedJul 14, 2023
  ae06fd0

Commits on May 8, 2023

• Add guidance for usage of description tags (e.g. [tag], #tag).

  

  code-health-devguide-copybara

  authored and

  Copybara-Service

  committedMay 8, 2023
  36833b7

Commits on Aug 17, 2022

• Added section related to comments severity

  

  code-health-devguide-copybara

  authored and

  Copybara-Service

  committedAug 17, 2022
  537567e

Commits on Jun 27, 2022

• Automated formatting changes.

  

  code-health-devguide-copybara

  authored and

  Copybara-Service

  committedJun 27, 2022
  ab034bf

Commits on Mar 31, 2022

• Update "Think for Yourself" to "Think Collaboratively".

  

  code-health-devguide-copybara

  authored and

  Copybara-Service

  committedMar 31, 2022
  716687a

• Be inclusive of Privacy anywhere Security is referenced.

  

  code-health-devguide-copybara

  authored and

  Copybara-Service

  committedMar 31, 2022
  3e6ba5c

Commits on Feb 8, 2022

• For cross-tz reviews give the author enough time to respond before the end of the day.

  

  code-health-devguide-copybara

  authored and

  Copybara-Service

  committedFeb 8, 2022
  0ab08d6

Commits on Jan 10, 2022

• Internal change

  

  code-health-devguide-copybara

  authored and

  Copybara-Service

  committedJan 10, 2022
  6cebf15

Commits on Oct 26, 2021

• Fix punctuation in go/review-speed:

  

  code-health-devguide-copybara

  authored and

  Copybara-Service

  committedOct 26, 2021
  3bb64aa

Commits on Oct 7, 2021

• Change eng-practices Github Pages theme to jekyll-theme-primer.

  

  code-health-devguide-copybara

  authored and

  Copybara-Service

  committedOct 7, 2021
  5dfc4de

Commits on Jul 9, 2021

• Fixing broken link.

  

  adambender

  authored and

  Copybara-Service

  committedJul 9, 2021
  deaff2f

Commits on Jul 7, 2021

• Clarify what the "rest" is contrasting in Google eng-practices documentation.

  

  Michael Sheely

  authored and

  Copybara-Service

  committedJul 7, 2021
  e537051

Commits on Apr 28, 2021

• Internal change

  

  code-health-devguide-copybara

  authored and

  Copybara-Service

  committedApr 28, 2021
  27fbdb5

Commits on Mar 18, 2021

• Add tips for handling partial reviews.

  

  code-health-devguide-copybara

  authored and

  Copybara-Service

  committedMar 18, 2021
  3a17d63

• Internal change

  

  code-health-devguide-copybara

  authored and

  Copybara-Service

  committedMar 18, 2021
  40e621a

Commits on Mar 10, 2021

• Update permalinks on "What to look for..." to use dashes instead of underscores.

  

  code-health-devguide-copybara

  authored and

  Copybara-Service

  committedMar 10, 2021
  cea9d7a

Commits on Nov 18, 2020

• Remove disrespectful terminology ("sanity check")

  

  code-health-devguide-copybara

  authored and

  Copybara-Service

  committedNov 18, 2020
  e849e00

Commits on Oct 27, 2020

• Clarify what it means for the style guide to be a recommendation.

  

  amalloy

  authored and

  Copybara-Service

  committedOct 27, 2020
  b8bfaab

Commits on Aug 4, 2020

• Add missing comma.

  

  ninabikes

  authored and

  Copybara-Service

  committedAug 4, 2020
  eaff1ef

• Internal change

  

  adambender

  authored and

  Copybara-Service

  committedAug 4, 2020
  68b39c4

• Internal change

  

  code-health-devguide-copybara

  authored and

  Copybara-Service

  committedAug 4, 2020
  fe113b3

Commits on Jul 31, 2020

• Merge pull request google#14 from alanyee/patch-1

  adambender

  committedJul 31, 2020
  f81aa27

• Merge pull request google#30 from michaelrbock/patch-2

  adambender

  committedJul 31, 2020
  5bc2e3a

• Merge branch 'master' into patch-2

  adambender

  committedJul 31, 2020
  5c8e8a0

• Merge pull request google#26 from fractalists/master

  adambender

  committedJul 31, 2020
  c203258

Commits on Jul 30, 2020

• Make the "test code" section clearer about the expectation that CLs should include relevant tests.

  

  code-health-devguide-copybara

  authored and

  Copybara-Service

  committedJul 30, 2020
  3f527b1

Commits on Jul 28, 2020

• Fix link for Respectful Code Reviews: https://chromium.googlesource.com/chromium/src/+/master/docs/cr_respect.md

  

  code-health-devguide-copybara

  authored and

  Copybara-Service

  committedJul 28, 2020
  5e85129

Commits on Jul 23, 2020

• Update to include pull request as synonym for CL

  michaelrbock

  committedJul 23, 2020
  3a7ba63

Commits on Jun 30, 2020

• Add ways for a CL reviewer to encourage CL authors to continue their good practices.

  

  code-health-devguide-copybara

  authored and

  Copybara-Service

  committedJun 30, 2020
  fb6413e

Pagination

PreviousNext