Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pip update causes a local build directory creation #1456

Closed
PythonCoderAS opened this issue Apr 29, 2020 · 2 comments · Fixed by #1457
Closed

Pip update causes a local build directory creation #1456

PythonCoderAS opened this issue Apr 29, 2020 · 2 comments · Fixed by #1457
Assignees
Labels
Developer Environment Related to the development process

Comments

@PythonCoderAS
Copy link
Contributor

Prior to the latest version of pip, if you did pip install ., pip would copy the current directory to a tempdir and make the build files there. However, with the merge of pypa/pip#7882, builds are done in place. This creates a build directory that basically contains a copy of the source files.

This causes flake8 to see those files and work on them as well. Now this is not good because the build directory is not in the flake8 ignore.

There are two ways to deal with this:

  1. Pin pip to the previous version. Not recommended, and also the push leads to faster CI times.
  2. Delete the build directory. This is the recommended option.
@PythonCoderAS PythonCoderAS added Developer Environment Related to the development process Critical Something important isn't working labels Apr 29, 2020
@PythonCoderAS PythonCoderAS self-assigned this Apr 29, 2020
@jarhill0
Copy link
Contributor

Let's delete the build directory (or tell linting to ignore it).

@jarhill0
Copy link
Contributor

Also, I don't think this counts as critical — certainly our CI won't pass until it's fixed, but it's not like there's an active critical bug in PRAW itself. So I'm going to remove that label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer Environment Related to the development process
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants