Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WheelBuilder: use python version as cache key #152

Closed
tdejager opened this issue Jan 19, 2024 · 3 comments
Closed

WheelBuilder: use python version as cache key #152

tdejager opened this issue Jan 19, 2024 · 3 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@tdejager
Copy link
Contributor

When building wheels with a source distribution, we also need to take the the PythonVersion into account when hitting the cache. Currently, we only use the contents of the sdist.

When creating the WheelKey we should probably add this to the hash.

Pixi will also need to supply this information later.

@baszalmstra when using this in the content-hash it will not actually be the content, but I don't think we can utilize the cacache metadata in this case. We could also associate it with a specific key, WDYT?

@baszalmstra
Copy link
Contributor

Yeah you'd need to add the python version as part of the key.

@tdejager tdejager added bug Something isn't working enhancement New feature or request labels Jan 19, 2024
@tdejager tdejager self-assigned this Jan 19, 2024
@baszalmstra
Copy link
Contributor

Yeah in that case the Python-version needs to be part of the key. So if you would use the shahash as the key previously now it would be something along the lines of:

<sha>-<python-version>

You can of course encode anything in the key.

@tdejager
Copy link
Contributor Author

Closed by: #159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants