Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making PythonInterpreterVersion public API #155

Closed
mattem opened this issue Jan 20, 2024 · 5 comments · Fixed by #158
Closed

Consider making PythonInterpreterVersion public API #155

mattem opened this issue Jan 20, 2024 · 5 comments · Fixed by #158

Comments

@mattem
Copy link
Contributor

mattem commented Jan 20, 2024

Hi, I'm a maintainer on the Bazel build system, and rules_py. I'm looking to make use of VEnv in the rattler_installs_packages crate.

We have a requirement where we are unable to call the Python interpreter to determine its version, however we already know the interpreters version statically ahead of time, but as PythonInterpreterVersion isn't public, we can't make use VEnv::create_pyvenv to workaround the version interrogation in VEnv::create_custom.

What are the thoughts around either moving PythonInterpreterVersion to the public API, or providing another function on VEnv that takes a version string or tuple?

@tdejager
Copy link
Contributor

Sounds good! What would you prefer? Open to both:)

@mattem
Copy link
Contributor Author

mattem commented Jan 20, 2024

I think my preference would be making it public.

@tdejager
Copy link
Contributor

Okay, if you want to make a PR go ahead! Otherwise I'll get to it the coming week :)

@mattem
Copy link
Contributor Author

mattem commented Jan 20, 2024

Great! I can put up a PR 👍

@tdejager
Copy link
Contributor

Thanks for the PR 😀 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants