From e74e5810590ea389a8594153a60b45e6b37f69b3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Arma=C4=9Fan?= Date: Mon, 12 Aug 2024 08:57:03 +1000 Subject: [PATCH 1/2] chore(deps): Bump eslint-plugin-primer-react to v5.4.0 and update the code accordingly (#4766) * Update primer-react eslint plugin and update the code accordignly * fix linting * disable the rule * disable the rule * Create honest-ligers-fly.md * add role region for pagelayout content --- .changeset/honest-ligers-fly.md | 5 +++ .eslintrc.js | 3 +- docs/content/ActionMenu.mdx | 6 ++- package-lock.json | 42 +++---------------- package.json | 2 +- .../src/ActionList/ActionList.dev.stories.tsx | 2 + packages/react/src/ActionList/Item.tsx | 2 +- .../ActionMenu.features.stories.tsx | 3 +- .../src/Button/IconButton.dev.stories.tsx | 19 +-------- .../Button/IconButton.features.stories.tsx | 42 +++++-------------- .../react/src/Button/IconButton.stories.tsx | 2 +- .../src/Button/__tests__/Button.test.tsx | 30 +++---------- .../ButtonGroup.features.stories.tsx | 2 + .../__snapshots__/NavList.test.tsx.snap | 16 +++---- .../PageHeader.examples.stories.tsx | 2 - .../PageLayout.features.stories.tsx | 4 +- .../react/src/__tests__/ActionMenu.test.tsx | 2 +- .../__snapshots__/Autocomplete.test.tsx.snap | 10 ++--- .../drafts/MarkdownEditor/_ToolbarButton.tsx | 3 +- 19 files changed, 61 insertions(+), 136 deletions(-) create mode 100644 .changeset/honest-ligers-fly.md diff --git a/.changeset/honest-ligers-fly.md b/.changeset/honest-ligers-fly.md new file mode 100644 index 00000000000..231f0c8fc65 --- /dev/null +++ b/.changeset/honest-ligers-fly.md @@ -0,0 +1,5 @@ +--- +"@primer/react": patch +--- + +chore(deps): Update eslint-plugin-primer-react to latest diff --git a/.eslintrc.js b/.eslintrc.js index 43ed40e5530..77286a7ae85 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -75,7 +75,6 @@ module.exports = { ], }, ], - 'primer-react/no-deprecated-colors': ['warn', {checkAllStrings: true}], // Overrides from updating plugin:github 'filenames/match-regex': 'off', @@ -89,6 +88,7 @@ module.exports = { 'github/no-inner-html': 'off', 'github/role-supports-aria-props': 'off', 'no-restricted-syntax': 'off', + 'primer-react/a11y-use-next-tooltip': 'off', }, overrides: [ // rules which apply only to JS @@ -241,7 +241,6 @@ module.exports = { 'jsx-a11y/label-has-for': 'off', '@typescript-eslint/no-unnecessary-condition': 'off', '@typescript-eslint/no-unused-vars': 'off', - 'primer-react/no-deprecated-colors': ['error', {skipImportCheck: true}], 'no-redeclare': 'off', 'ssr-friendly/no-dom-globals-in-module-scope': 'off', 'ssr-friendly/no-dom-globals-in-react-fc': 'off', diff --git a/docs/content/ActionMenu.mdx b/docs/content/ActionMenu.mdx index 89768e6ae67..e8f9de88087 100644 --- a/docs/content/ActionMenu.mdx +++ b/docs/content/ActionMenu.mdx @@ -121,7 +121,8 @@ You can choose to have a different _anchor_ for the Menu depending on the applic - + + Live query @@ -130,7 +131,8 @@ You can choose to have a different _anchor_ for the Menu depending on the applic - + + Layout diff --git a/package-lock.json b/package-lock.json index 44f9e461428..e6ed1c77d39 100644 --- a/package-lock.json +++ b/package-lock.json @@ -36,7 +36,7 @@ "eslint-plugin-mdx": "3.0.0", "eslint-plugin-playwright": "0.15.1", "eslint-plugin-prettier": "5.0.0", - "eslint-plugin-primer-react": "4.0.2", + "eslint-plugin-primer-react": "5.4.0", "eslint-plugin-react": "7.32.2", "eslint-plugin-react-hooks": "4.6.0", "eslint-plugin-ssr-friendly": "1.3.0", @@ -28990,50 +28990,20 @@ } }, "node_modules/eslint-plugin-primer-react": { - "version": "4.0.2", + "version": "5.4.0", + "resolved": "https://registry.npmjs.org/eslint-plugin-primer-react/-/eslint-plugin-primer-react-5.4.0.tgz", + "integrity": "sha512-t3F8RGOG+88SOZTjC5+ZBDhLIJitlRN4qkdRmwDuaL5mkxIA4LzyhLf4KfM595NwDan8mj37Fjbt3Nj04PxUDQ==", "dev": true, - "license": "MIT", "dependencies": { "@styled-system/props": "^5.1.5", - "eslint-plugin-github": "^4.9.2", + "eslint-plugin-github": "^5.0.1", "eslint-plugin-jsx-a11y": "^6.7.1", "eslint-traverse": "^1.0.0", "lodash": "^4.17.21", "styled-system": "^5.1.5" }, "peerDependencies": { - "@primer/primitives": ">=4.6.2", - "eslint": "^8.0.1" - } - }, - "node_modules/eslint-plugin-primer-react/node_modules/eslint-plugin-github": { - "version": "4.10.2", - "dev": true, - "license": "MIT", - "dependencies": { - "@github/browserslist-config": "^1.0.0", - "@typescript-eslint/eslint-plugin": "^7.0.1", - "@typescript-eslint/parser": "^7.0.1", - "aria-query": "^5.3.0", - "eslint-config-prettier": ">=8.0.0", - "eslint-plugin-escompat": "^3.3.3", - "eslint-plugin-eslint-comments": "^3.2.0", - "eslint-plugin-filenames": "^1.3.2", - "eslint-plugin-i18n-text": "^1.0.1", - "eslint-plugin-import": "^2.25.2", - "eslint-plugin-jsx-a11y": "^6.7.1", - "eslint-plugin-no-only-tests": "^3.0.0", - "eslint-plugin-prettier": "^5.0.0", - "eslint-rule-documentation": ">=1.0.0", - "jsx-ast-utils": "^3.3.2", - "prettier": "^3.0.0", - "svg-element-attributes": "^1.3.1" - }, - "bin": { - "eslint-ignore-errors": "bin/eslint-ignore-errors.js" - }, - "peerDependencies": { - "eslint": "^8.0.1" + "eslint": "^8.42.0" } }, "node_modules/eslint-plugin-react": { diff --git a/package.json b/package.json index 41810e7ef9a..970ddfbca40 100644 --- a/package.json +++ b/package.json @@ -64,7 +64,7 @@ "eslint-plugin-mdx": "3.0.0", "eslint-plugin-playwright": "0.15.1", "eslint-plugin-prettier": "5.0.0", - "eslint-plugin-primer-react": "4.0.2", + "eslint-plugin-primer-react": "5.4.0", "eslint-plugin-react": "7.32.2", "eslint-plugin-react-hooks": "4.6.0", "eslint-plugin-ssr-friendly": "1.3.0", diff --git a/packages/react/src/ActionList/ActionList.dev.stories.tsx b/packages/react/src/ActionList/ActionList.dev.stories.tsx index 7140aebb244..4578ddb7e59 100644 --- a/packages/react/src/ActionList/ActionList.dev.stories.tsx +++ b/packages/react/src/ActionList/ActionList.dev.stories.tsx @@ -41,6 +41,7 @@ export const GroupWithSubtleTitleOldAPI = () => { under features.

+ {/* eslint-disable-next-line primer-react/no-deprecated-props */} {users.slice(2).map(user => ( { under features.

+ {/* eslint-disable-next-line primer-react/no-deprecated-props */} {users.slice(2).map(user => ( ( cursor: 'not-allowed', '[data-component="ActionList.Checkbox"]': { cursor: 'not-allowed', - bg: selected ? 'fg.muted' : 'var(--color-input-disabled-bg, rgba(175, 184, 193, 0.2))', + bg: selected ? 'fg.muted' : 'var(--control-bgColor-disabled, rgba(175, 184, 193, 0.2))', borderColor: selected ? 'fg.muted' : 'var(--color-input-disabled-bg, rgba(175, 184, 193, 0.2))', }, }, diff --git a/packages/react/src/ActionMenu/ActionMenu.features.stories.tsx b/packages/react/src/ActionMenu/ActionMenu.features.stories.tsx index 7913ed14af2..ab68345afe1 100644 --- a/packages/react/src/ActionMenu/ActionMenu.features.stories.tsx +++ b/packages/react/src/ActionMenu/ActionMenu.features.stories.tsx @@ -219,7 +219,8 @@ export const LoadingItems = () => ( - + + Github projects What's new diff --git a/packages/react/src/Button/IconButton.dev.stories.tsx b/packages/react/src/Button/IconButton.dev.stories.tsx index 87b0c60a31c..36e75d6b350 100644 --- a/packages/react/src/Button/IconButton.dev.stories.tsx +++ b/packages/react/src/Button/IconButton.dev.stories.tsx @@ -7,14 +7,7 @@ export default { } export const CustomSize = () => ( - + ) export const CustomSizeWithMedia = () => { @@ -24,19 +17,11 @@ export const CustomSizeWithMedia = () => { variant="primary" size="small" icon={ChevronDownIcon} - unsafeDisableTooltip={false} sx={{'@media (min-width: 123px)': {width: 16, height: 16}}} /> ) } export const CustomIconColor = () => ( - + ) diff --git a/packages/react/src/Button/IconButton.features.stories.tsx b/packages/react/src/Button/IconButton.features.stories.tsx index 5d00b7678b3..e8581bd6482 100644 --- a/packages/react/src/Button/IconButton.features.stories.tsx +++ b/packages/react/src/Button/IconButton.features.stories.tsx @@ -10,41 +10,22 @@ export default { title: 'Components/IconButton/Features', } -export const Primary = () => ( - -) +export const Primary = () => -export const Danger = () => ( - -) +export const Danger = () => -export const Invisible = () => ( - -) +export const Invisible = () => -export const Disabled = () => ( - -) +export const Disabled = () => -export const Small = () => ( - -) +export const Small = () => -export const Medium = () => ( - -) +export const Medium = () => -export const Large = () => ( - -) +export const Large = () => export const WithDescription = () => ( - + ) export const ExternalTooltip = () => ( @@ -62,7 +43,7 @@ export const ExternalTooltipVersion1 = () => ( export const AsAMenuAnchor = () => ( - + @@ -105,7 +86,6 @@ export const LoadingTrigger = () => { } export const KeyshortcutsOnDescription = () => ( ( /> ) -export const Keyshortcuts = () => ( - -) +export const Keyshortcuts = () => diff --git a/packages/react/src/Button/IconButton.stories.tsx b/packages/react/src/Button/IconButton.stories.tsx index 04c7dc64470..845fa4b5415 100644 --- a/packages/react/src/Button/IconButton.stories.tsx +++ b/packages/react/src/Button/IconButton.stories.tsx @@ -46,4 +46,4 @@ Playground.args = { icon: HeartIcon, } -export const Default = () => +export const Default = () => diff --git a/packages/react/src/Button/__tests__/Button.test.tsx b/packages/react/src/Button/__tests__/Button.test.tsx index 976cb5c8474..09b8bb8ff7d 100644 --- a/packages/react/src/Button/__tests__/Button.test.tsx +++ b/packages/react/src/Button/__tests__/Button.test.tsx @@ -251,16 +251,14 @@ describe('Button', () => { }) it('should render tooltip on an icon button when unsafeDisableTooltip prop is passed as false', () => { - const {getByRole, getByText} = render( - , - ) + const {getByRole, getByText} = render() const triggerEL = getByRole('button') const tooltipEl = getByText('Heart') expect(triggerEL).toHaveAttribute('aria-labelledby', tooltipEl.id) }) it('should render description type tooltip on an icon button when unsafeDisableTooltip prop is passed as false', () => { const {getByRole, getByText} = render( - , + , ) const triggerEL = getByRole('button') expect(triggerEL).toHaveAttribute('aria-label', 'Heart') @@ -275,16 +273,12 @@ describe('Button', () => { expect(triggerEl).not.toHaveAttribute('aria-label') }) it('should render aria-keyshorts on an icon button when keyshortcuts prop is passed', () => { - const {getByRole} = render( - , - ) + const {getByRole} = render() const triggerEl = getByRole('button') expect(triggerEl).toHaveAttribute('aria-keyshortcuts', 'Command+H') }) it('should append the keyshortcuts to the tooltip text that labels the icon button when keyshortcuts prop is passed', () => { - const {getByRole, getByText} = render( - , - ) + const {getByRole, getByText} = render() const triggerEl = getByRole('button') const tooltipEl = getByText('Heart, Command+H') expect(tooltipEl).toBeInTheDocument() @@ -292,26 +286,14 @@ describe('Button', () => { }) it('should render aria-keyshorts on an icon button when keyshortcuts prop is passed (Description Type)', () => { const {getByRole} = render( - , + , ) const triggerEl = getByRole('button') expect(triggerEl).toHaveAttribute('aria-keyshortcuts', 'Command+H') }) it('should append the keyshortcuts to the tooltip text that describes the icon button when keyshortcuts prop is passed (Description Type)', () => { const {getByRole, getByText} = render( - , + , ) const triggerEl = getByRole('button') const tooltipEl = getByText('Love is all around, Command+H') diff --git a/packages/react/src/ButtonGroup/ButtonGroup.features.stories.tsx b/packages/react/src/ButtonGroup/ButtonGroup.features.stories.tsx index a1773b5a703..464f8f4a416 100644 --- a/packages/react/src/ButtonGroup/ButtonGroup.features.stories.tsx +++ b/packages/react/src/ButtonGroup/ButtonGroup.features.stories.tsx @@ -12,7 +12,9 @@ export default { export const IconButtons = () => ( {/* We can remove these unsafe props after we resolve https://github.com/primer/react/issues/4129 */} + {/* eslint-disable-next-line primer-react/a11y-remove-disable-tooltip */} + {/* eslint-disable-next-line primer-react/a11y-remove-disable-tooltip */} ) diff --git a/packages/react/src/NavList/__snapshots__/NavList.test.tsx.snap b/packages/react/src/NavList/__snapshots__/NavList.test.tsx.snap index c46f758c1af..0444eca4c9b 100644 --- a/packages/react/src/NavList/__snapshots__/NavList.test.tsx.snap +++ b/packages/react/src/NavList/__snapshots__/NavList.test.tsx.snap @@ -87,7 +87,7 @@ exports[`NavList renders a simple list 1`] = ` .c2[aria-disabled] [data-component="ActionList.Checkbox"], .c2[data-inactive] [data-component="ActionList.Checkbox"] { cursor: not-allowed; - background-color: var(--color-input-disabled-bg,rgba(175,184,193,0.2)); + background-color: var(--control-bgColor-disabled,rgba(175,184,193,0.2)); border-color: var(--color-input-disabled-bg,rgba(175,184,193,0.2)); } @@ -179,7 +179,7 @@ exports[`NavList renders a simple list 1`] = ` .c7[aria-disabled] [data-component="ActionList.Checkbox"], .c7[data-inactive] [data-component="ActionList.Checkbox"] { cursor: not-allowed; - background-color: var(--color-input-disabled-bg,rgba(175,184,193,0.2)); + background-color: var(--control-bgColor-disabled,rgba(175,184,193,0.2)); border-color: var(--color-input-disabled-bg,rgba(175,184,193,0.2)); } @@ -545,7 +545,7 @@ exports[`NavList renders with groups 1`] = ` .c6[aria-disabled] [data-component="ActionList.Checkbox"], .c6[data-inactive] [data-component="ActionList.Checkbox"] { cursor: not-allowed; - background-color: var(--color-input-disabled-bg,rgba(175,184,193,0.2)); + background-color: var(--control-bgColor-disabled,rgba(175,184,193,0.2)); border-color: var(--color-input-disabled-bg,rgba(175,184,193,0.2)); } @@ -637,7 +637,7 @@ exports[`NavList renders with groups 1`] = ` .c11[aria-disabled] [data-component="ActionList.Checkbox"], .c11[data-inactive] [data-component="ActionList.Checkbox"] { cursor: not-allowed; - background-color: var(--color-input-disabled-bg,rgba(175,184,193,0.2)); + background-color: var(--control-bgColor-disabled,rgba(175,184,193,0.2)); border-color: var(--color-input-disabled-bg,rgba(175,184,193,0.2)); } @@ -1022,7 +1022,7 @@ exports[`NavList.Item with NavList.SubNav does not have active styles if SubNav .c11[aria-disabled] [data-component="ActionList.Checkbox"], .c11[data-inactive] [data-component="ActionList.Checkbox"] { cursor: not-allowed; - background-color: var(--color-input-disabled-bg,rgba(175,184,193,0.2)); + background-color: var(--control-bgColor-disabled,rgba(175,184,193,0.2)); border-color: var(--color-input-disabled-bg,rgba(175,184,193,0.2)); } @@ -1114,7 +1114,7 @@ exports[`NavList.Item with NavList.SubNav does not have active styles if SubNav .c4[aria-disabled] [data-component="ActionList.Checkbox"], .c4[data-inactive] [data-component="ActionList.Checkbox"] { cursor: not-allowed; - background-color: var(--color-input-disabled-bg,rgba(175,184,193,0.2)); + background-color: var(--control-bgColor-disabled,rgba(175,184,193,0.2)); border-color: var(--color-input-disabled-bg,rgba(175,184,193,0.2)); } @@ -1493,7 +1493,7 @@ exports[`NavList.Item with NavList.SubNav has active styles if SubNav contains t .c11[aria-disabled] [data-component="ActionList.Checkbox"], .c11[data-inactive] [data-component="ActionList.Checkbox"] { cursor: not-allowed; - background-color: var(--color-input-disabled-bg,rgba(175,184,193,0.2)); + background-color: var(--control-bgColor-disabled,rgba(175,184,193,0.2)); border-color: var(--color-input-disabled-bg,rgba(175,184,193,0.2)); } @@ -1595,7 +1595,7 @@ exports[`NavList.Item with NavList.SubNav has active styles if SubNav contains t .c4[aria-disabled] [data-component="ActionList.Checkbox"], .c4[data-inactive] [data-component="ActionList.Checkbox"] { cursor: not-allowed; - background-color: var(--color-input-disabled-bg,rgba(175,184,193,0.2)); + background-color: var(--control-bgColor-disabled,rgba(175,184,193,0.2)); border-color: var(--color-input-disabled-bg,rgba(175,184,193,0.2)); } diff --git a/packages/react/src/PageHeader/PageHeader.examples.stories.tsx b/packages/react/src/PageHeader/PageHeader.examples.stories.tsx index dbb256d9e9d..e0024100b61 100644 --- a/packages/react/src/PageHeader/PageHeader.examples.stories.tsx +++ b/packages/react/src/PageHeader/PageHeader.examples.stories.tsx @@ -430,7 +430,6 @@ export const IssuesPage = () => { aria-label="Copy permalink" icon={CopyIcon} variant="invisible" - unsafeDisableTooltip={false} onClick={() => { alert('This button copies the permalink to the clipboard') }} @@ -459,7 +458,6 @@ export const IssuesPage = () => { aria-label="Copy permalink" icon={CopyIcon} variant="invisible" - unsafeDisableTooltip={false} onClick={() => { alert('This button copies the permalink to the clipboard') }} diff --git a/packages/react/src/PageLayout/PageLayout.features.stories.tsx b/packages/react/src/PageLayout/PageLayout.features.stories.tsx index 0e78dd724bb..af5f5b18ef2 100644 --- a/packages/react/src/PageLayout/PageLayout.features.stories.tsx +++ b/packages/react/src/PageLayout/PageLayout.features.stories.tsx @@ -162,7 +162,7 @@ export const NestedScrollContainer: StoryFn = args => ( - + {Array.from({length: args.numParagraphsInContent}).map((_, i) => ( Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nam at enim id lorem tempus egestas a non @@ -334,7 +334,7 @@ export const ScrollContainerWithinPageLayoutPane: StoryFn = () => ( - + diff --git a/packages/react/src/__tests__/ActionMenu.test.tsx b/packages/react/src/__tests__/ActionMenu.test.tsx index 91533a83b3a..7028221595b 100644 --- a/packages/react/src/__tests__/ActionMenu.test.tsx +++ b/packages/react/src/__tests__/ActionMenu.test.tsx @@ -497,7 +497,7 @@ describe('ActionMenu', () => { - + diff --git a/packages/react/src/__tests__/__snapshots__/Autocomplete.test.tsx.snap b/packages/react/src/__tests__/__snapshots__/Autocomplete.test.tsx.snap index c4c070b666e..9f40a07fbc8 100644 --- a/packages/react/src/__tests__/__snapshots__/Autocomplete.test.tsx.snap +++ b/packages/react/src/__tests__/__snapshots__/Autocomplete.test.tsx.snap @@ -750,7 +750,7 @@ exports[`snapshots renders a menu that contains an item to add to the menu 1`] = .c3[aria-disabled] [data-component="ActionList.Checkbox"], .c3[data-inactive] [data-component="ActionList.Checkbox"] { cursor: not-allowed; - background-color: var(--color-input-disabled-bg,rgba(175,184,193,0.2)); + background-color: var(--control-bgColor-disabled,rgba(175,184,193,0.2)); border-color: var(--color-input-disabled-bg,rgba(175,184,193,0.2)); } @@ -1526,7 +1526,7 @@ exports[`snapshots renders a multiselect input 1`] = ` .c3[aria-disabled] [data-component="ActionList.Checkbox"], .c3[data-inactive] [data-component="ActionList.Checkbox"] { cursor: not-allowed; - background-color: var(--color-input-disabled-bg,rgba(175,184,193,0.2)); + background-color: var(--control-bgColor-disabled,rgba(175,184,193,0.2)); border-color: var(--color-input-disabled-bg,rgba(175,184,193,0.2)); } @@ -2355,7 +2355,7 @@ exports[`snapshots renders a multiselect input with selected menu items 1`] = ` .c8[aria-disabled] [data-component="ActionList.Checkbox"], .c8[data-inactive] [data-component="ActionList.Checkbox"] { cursor: not-allowed; - background-color: var(--color-input-disabled-bg,rgba(175,184,193,0.2)); + background-color: var(--control-bgColor-disabled,rgba(175,184,193,0.2)); border-color: var(--color-input-disabled-bg,rgba(175,184,193,0.2)); } @@ -3048,7 +3048,7 @@ exports[`snapshots renders a single select input 1`] = ` .c3[aria-disabled] [data-component="ActionList.Checkbox"], .c3[data-inactive] [data-component="ActionList.Checkbox"] { cursor: not-allowed; - background-color: var(--color-input-disabled-bg,rgba(175,184,193,0.2)); + background-color: var(--control-bgColor-disabled,rgba(175,184,193,0.2)); border-color: var(--color-input-disabled-bg,rgba(175,184,193,0.2)); } @@ -3518,7 +3518,7 @@ exports[`snapshots renders with a custom text input component 1`] = ` .c3[aria-disabled] [data-component="ActionList.Checkbox"], .c3[data-inactive] [data-component="ActionList.Checkbox"] { cursor: not-allowed; - background-color: var(--color-input-disabled-bg,rgba(175,184,193,0.2)); + background-color: var(--control-bgColor-disabled,rgba(175,184,193,0.2)); border-color: var(--color-input-disabled-bg,rgba(175,184,193,0.2)); } diff --git a/packages/react/src/drafts/MarkdownEditor/_ToolbarButton.tsx b/packages/react/src/drafts/MarkdownEditor/_ToolbarButton.tsx index 8b138d747d8..cd2e8788550 100644 --- a/packages/react/src/drafts/MarkdownEditor/_ToolbarButton.tsx +++ b/packages/react/src/drafts/MarkdownEditor/_ToolbarButton.tsx @@ -7,7 +7,9 @@ export const ToolbarButton = forwardRef((pro const {disabled, condensed} = useContext(MarkdownEditorContext) return ( + // eslint-disable-next-line primer-react/a11y-remove-disable-tooltip ((pro {...props} sx={{color: 'fg.muted', ...props.sx}} // Keeping the tooltip disable since it is not maintained anymore and its tests were failing. - unsafeDisableTooltip /> ) }) From c0a4c3f442836ce32e072bfe1e92814a1b14f850 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Sun, 11 Aug 2024 23:13:17 +0000 Subject: [PATCH 2/2] Version Packages (rc) --- .changeset/pre.json | 5 +++++ examples/app-router/package.json | 2 +- examples/codesandbox/package.json | 2 +- examples/consumer-test/package.json | 2 +- examples/nextjs/package.json | 2 +- packages/react/CHANGELOG.md | 16 ++++++++++++++++ packages/react/package.json | 2 +- 7 files changed, 26 insertions(+), 5 deletions(-) diff --git a/.changeset/pre.json b/.changeset/pre.json index 761540c5054..1fa7a717591 100644 --- a/.changeset/pre.json +++ b/.changeset/pre.json @@ -13,12 +13,17 @@ }, "changesets": [ "beige-schools-kneel", + "clever-birds-press", "dry-trainers-protect", "fluffy-ravens-thank", "four-shoes-yell", "four-tables-glow", + "honest-ligers-fly", "lovely-days-march", "moody-rivers-impress", + "new-shirts-beam", + "tall-wasps-end", + "tough-pans-punch", "young-meals-worry" ] } diff --git a/examples/app-router/package.json b/examples/app-router/package.json index 8c0fc1de69f..4667180ef19 100644 --- a/examples/app-router/package.json +++ b/examples/app-router/package.json @@ -10,7 +10,7 @@ "type-check": "tsc --noEmit" }, "dependencies": { - "@primer/react": "37.0.0-rc.0", + "@primer/react": "37.0.0-rc.1", "next": "^14.1.0", "react": "^18.3.1", "react-dom": "^18.3.1", diff --git a/examples/codesandbox/package.json b/examples/codesandbox/package.json index 6ff8acc7399..7136e5ec74d 100644 --- a/examples/codesandbox/package.json +++ b/examples/codesandbox/package.json @@ -20,7 +20,7 @@ "@typescript-eslint/eslint-plugin": "^7.11.0", "@typescript-eslint/parser": "^7.3.1", "@vitejs/plugin-react": "^4.2.1", - "@primer/react": "37.0.0-rc.0", + "@primer/react": "37.0.0-rc.1", "eslint": "^8.56.0", "eslint-plugin-react-hooks": "^4.6.0", "eslint-plugin-react-refresh": "^0.4.7", diff --git a/examples/consumer-test/package.json b/examples/consumer-test/package.json index fd93db20f38..47d42f1845e 100644 --- a/examples/consumer-test/package.json +++ b/examples/consumer-test/package.json @@ -9,7 +9,7 @@ "@types/react": "^18.2.14", "@types/react-dom": "^18.2.19", "@types/styled-components": "^5.1.11", - "@primer/react": "37.0.0-rc.0", + "@primer/react": "37.0.0-rc.1", "react": "^18.0.0", "react-dom": "^18.0.0", "styled-components": "^5.3.11", diff --git a/examples/nextjs/package.json b/examples/nextjs/package.json index ada469180d9..62a3b3563b5 100644 --- a/examples/nextjs/package.json +++ b/examples/nextjs/package.json @@ -10,7 +10,7 @@ }, "dependencies": { "@primer/octicons-react": "19.x", - "@primer/react": "37.0.0-rc.0", + "@primer/react": "37.0.0-rc.1", "next": "^14.1.0", "react": "^18.3.1", "react-dom": "^18.3.1", diff --git a/packages/react/CHANGELOG.md b/packages/react/CHANGELOG.md index 7ca28830038..1f8bd4a3c1f 100644 --- a/packages/react/CHANGELOG.md +++ b/packages/react/CHANGELOG.md @@ -1,5 +1,21 @@ # @primer/react +## 37.0.0-rc.1 + +### Minor Changes + +- [#4824](https://github.com/primer/react/pull/4824) [`b85d5057d2576a4bad37469daeb8ef66d34091cd`](https://github.com/primer/react/commit/b85d5057d2576a4bad37469daeb8ef66d34091cd) Thanks [@iansan5653](https://github.com/iansan5653)! - Adds new `className` prop to `FormControl` component + +- [#4810](https://github.com/primer/react/pull/4810) [`c0425ff7d0b9572f7551f114133fd0302980815f`](https://github.com/primer/react/commit/c0425ff7d0b9572f7551f114133fd0302980815f) Thanks [@joshblack](https://github.com/joshblack)! - Update Blankslate component to use CSS Modules behind a feature flag + +### Patch Changes + +- [#4806](https://github.com/primer/react/pull/4806) [`84d1604ecf2c07b5584f7c5db2cd078c18847cbf`](https://github.com/primer/react/commit/84d1604ecf2c07b5584f7c5db2cd078c18847cbf) Thanks [@langermank](https://github.com/langermank)! - Add `variant` prop to Heading for small, medium and large styles + +- [#4766](https://github.com/primer/react/pull/4766) [`e74e5810590ea389a8594153a60b45e6b37f69b3`](https://github.com/primer/react/commit/e74e5810590ea389a8594153a60b45e6b37f69b3) Thanks [@broccolinisoup](https://github.com/broccolinisoup)! - chore(deps): Update eslint-plugin-primer-react to latest + +- [#4816](https://github.com/primer/react/pull/4816) [`f9bc73c167f4453cfb7a0636e72d216c6bd0d039`](https://github.com/primer/react/commit/f9bc73c167f4453cfb7a0636e72d216c6bd0d039) Thanks [@siddharthkp](https://github.com/siddharthkp)! - FilteredActionList: export `FilteredActionList` from '@primer/react/experimental' + ## 37.0.0-rc.0 ### Major Changes diff --git a/packages/react/package.json b/packages/react/package.json index a3c7e160bde..e8c46f839c4 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -1,6 +1,6 @@ { "name": "@primer/react", - "version": "37.0.0-rc.0", + "version": "37.0.0-rc.1", "description": "An implementation of GitHub's Primer Design System using React", "main": "lib/index.js", "module": "lib-esm/index.js",